MNG-4463: Version ranges cannot be used for artifacts with 'import' scope #64

phang98 · 2015-09-04T06:11:49Z

MNG-4463: Version ranges cannot be used for artifacts with 'import' scope
This is a quick patch to support version range resolution for artifacts with pom import.

MNG-4463: allow pom import support version range resolution.

MNG-4463: Version ranges cannot be used for artifacts with 'import' scope

jvanzyl · 2015-09-11T23:38:01Z

Please squash your commits into a single commit.

phang98 · 2015-09-22T09:26:54Z

The other commit is on branch, does it matter?

jvanzyl · 2015-09-22T10:27:10Z

Generally the changes need to be squashed into a single commit and for changes to core you need a corresponding integration test. The integration tests can be found here https://github.com/apache/maven-integration-testing

phang98 · 2015-09-28T05:15:50Z

I'll look into the integration test part.

barthel · 2015-10-24T11:30:55Z

Since org.apache.maven.repository.internal.DefaultModelResolver.resolveModel(Parent) handles the version range and org.apache.maven.repository.internal.DefaultModelResolver.resolveModel(String, String, String) doesn't.

These differences are not described in org.apache.maven.model.resolution.ModelResolver.

@jvanzyl Should @phang98 adapt the javadoc or harmonize the behaviour?

barthel · 2015-11-23T17:52:56Z

I would like to see this behaviour in the next Maven (3.3.10) release.
@phang98 What's the status of the integration tests?
@jvanzyl Do you like to merge this change in the next release if all integration tests are passed?

michael-o · 2015-11-23T19:58:02Z

@barthel Please squash!

barthel · 2015-11-23T20:38:09Z

@michael-o Sorry. I'm not the owner of this PR. I only push that change forward.

michael-o · 2015-11-23T20:50:42Z

@barthel Sorry, messed you up.
@phang98 Can you make the requested changes?

phang98 · 2015-11-24T07:09:20Z

Hi guys,
I was away to focus on other critical project for the past few months. I'll get it done by this week. Sorry for the long waiting.

jvanzyl · 2015-11-24T11:50:10Z

No problem, the 3.3.10 release took so much longer than expected so everyone's schedules got thrown off. Either @michael-o or myself will look at it when you're ready. No rush.

tomdw · 2015-12-21T14:32:37Z

@phang98 any news yet on merging this pull request and getting it into the different 3.0.x, 3.1.x, ... maven versions?

jvanzyl · 2015-12-21T15:47:36Z

Also, is there a corresponding integration test? I will be offline for the most part over the next two weeks. I'm working on a Maven 4.x branch that touches almost everything so I can work on this provided the integration tests pass. By integration test I mean a test project with an integration test that exercises the new proposed behaviour here: https://github.com/apache/maven-integration-testing

phang98 · 2016-01-06T07:58:26Z

I apologize for not fulfill my earlier commitment. :(
Happy new year and get the new traction again on this topic.
Will spend some time this weekend if possible.

jvanzyl · 2016-01-06T12:24:14Z

No problem, many of us were on holiday and we'll sort it out eventually.

tomdw · 2016-01-23T09:05:00Z

@phang98 any idea when this will get integrated in a maven release? Preferably already in an small 3.0.x maven version as our setup currently requires it.

phang98 · 2016-02-01T07:00:16Z

Thanks for the effort.

…scope o Extended the 'ModelResolver' interface to support resolving 'Dependency's in addition to 'Parent's. Closes #64 without merging. ITs are pending to be committed.

o Extended the 'ModelResolver' interface to support resolving 'Dependency's in addition to 'Parent's. Closes #64 without merging. ITs are pending to be committed.

Closes apache#64 without merging. ITs are pending to be committed.

…scope o Extended the 'ModelResolver' interface to support resolving 'Dependency's in addition to 'Parent's. Closes #64 without merging. ITs are pending to be committed.

Closes #64 without merging. ITs are pending to be committed.

jira-importer · 2025-07-06T15:46:01Z

Resolve #8104

phang98 added 2 commits September 4, 2015 14:02

Update DefaultModelBuilder.java

c76ca33

MNG-4463: allow pom import support version range resolution.

Merge pull request #1 from phang98/phang98-patch-MNG-4463

43171cf

MNG-4463: Version ranges cannot be used for artifacts with 'import' scope

asfgit closed this in 2abeaf0 Jan 30, 2016

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Mar 17, 2017

[MNG-4463] Dependency management import should support version ranges.

2d28527

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Mar 17, 2017

[MNG-4463] Dependency management import should support version ranges.

1ab01a3

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Mar 18, 2017

[MNG-4463] Dependency management import should support version ranges.

0d7b8a7

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Mar 19, 2017

[MNG-4463] Dependency management import should support version ranges.

ea30087

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Mar 21, 2017

[MNG-4463] Dependency management import should support version ranges.

6951160

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Mar 25, 2017

[MNG-4463] Dependency management import should support version ranges.

d852730

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Mar 25, 2017

[MNG-4463] Dependency management import should support version ranges.

1b338d6

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Mar 31, 2017

[MNG-4463] Dependency management import should support version ranges.

4820280

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Mar 31, 2017

[MNG-4463] Dependency management import should support version ranges.

71ffffc

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Apr 8, 2017

[MNG-4463] Dependency management import should support version ranges.

1104481

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Apr 18, 2017

[MNG-4463] Dependency management import should support version ranges.

b6c257d

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Oct 22, 2017

[MNG-4463] Dependency management import should support version ranges.

69c7cba

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Dec 30, 2017

[MNG-4463] Dependency management import should support version ranges.

216d0d3

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Dec 31, 2017

[MNG-4463] Dependency management import should support version ranges.

10f9b4b

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Dec 31, 2017

[MNG-4463] Dependency management import should support version ranges.

9f236fd

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte mentioned this pull request Dec 31, 2017

[MNG-4463] Dependency management import should support version ranges. #146

Closed

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Feb 21, 2018

[MNG-4463] Dependency management import should support version ranges.

98cdbf3

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Mar 18, 2018

[MNG-4463] Dependency management import should support version ranges.

0e945e8

Closes apache#64 without merging. ITs are pending to be committed.

ChristianSchulte added a commit to ChristianSchulte/maven that referenced this pull request Apr 1, 2018

[MNG-4463] Dependency management import should support version ranges.

5aca687

Closes apache#64 without merging. ITs are pending to be committed.

asfgit pushed a commit that referenced this pull request Jan 13, 2019

[MNG-4463] Dependency management import should support version ranges.

6e4f086

Closes #64 without merging. ITs are pending to be committed.

asfgit pushed a commit that referenced this pull request Mar 29, 2019

[MNG-4463] Dependency management import should support version ranges.

c965cad

Closes #64 without merging. ITs are pending to be committed.

asfgit pushed a commit that referenced this pull request Apr 12, 2019

[MNG-4463] Dependency management import should support version ranges.

2b2791e

Closes #64 without merging. ITs are pending to be committed.

slachiewicz referenced this pull request in slachiewicz/maven Dec 26, 2019

[MNG-4463] Dependency management import should support version ranges.

c1a6176

Closes #64 without merging. ITs are pending to be committed.

slachiewicz referenced this pull request in slachiewicz/maven Feb 5, 2020

[MNG-4463] Dependency management import should support version ranges.

d7bcc92

Closes #64 without merging. ITs are pending to be committed.

slachiewicz referenced this pull request in slachiewicz/maven Feb 5, 2020

[MNG-4463] Dependency management import should support version ranges.

1a9deda

Closes #64 without merging. ITs are pending to be committed.

asfgit pushed a commit that referenced this pull request Mar 28, 2020

[MNG-4463] Dependency management import should support version ranges.

ace5530

Closes #64 without merging. ITs are pending to be committed.

gnodet added a commit to gnodet/maven that referenced this pull request Mar 27, 2025

Upgrade to maven 4.0.0-rc-2 (apache#64)

4ad98e8

gnodet mentioned this pull request Mar 27, 2025

[MNG-8642] Integrate the testing framework inside Maven Core #2193

Merged

MNG-4463: Version ranges cannot be used for artifacts with 'import' scope #64

MNG-4463: Version ranges cannot be used for artifacts with 'import' scope #64

Uh oh!

Conversation

phang98 commented Sep 4, 2015

Uh oh!

jvanzyl commented Sep 11, 2015

Uh oh!

phang98 commented Sep 22, 2015

Uh oh!

jvanzyl commented Sep 22, 2015

Uh oh!

phang98 commented Sep 28, 2015

Uh oh!

barthel commented Oct 24, 2015

Uh oh!

barthel commented Nov 23, 2015

Uh oh!

michael-o commented Nov 23, 2015

Uh oh!

barthel commented Nov 23, 2015

Uh oh!

michael-o commented Nov 23, 2015

Uh oh!

phang98 commented Nov 24, 2015

Uh oh!

jvanzyl commented Nov 24, 2015

Uh oh!

tomdw commented Dec 21, 2015

Uh oh!

jvanzyl commented Dec 21, 2015

Uh oh!

phang98 commented Jan 6, 2016

Uh oh!

jvanzyl commented Jan 6, 2016

Uh oh!

tomdw commented Jan 23, 2016

Uh oh!

phang98 commented Feb 1, 2016

Uh oh!

jira-importer commented Jul 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants