Skip to content

[MNG-6294] - Convert MavenPluginValidator into a JSR330 component #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Dufgui wants to merge 1 commit into from
Closed

[MNG-6294] - Convert MavenPluginValidator into a JSR330 component #470

Dufgui wants to merge 1 commit into from

Conversation

@Dufgui
Copy link
Contributor

@Dufgui Dufgui commented Apr 25, 2021 •
edited
Loading

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o
Copy link
Member

michael-o commented Apr 26, 2021

Please note that there is already a PR for this issue...

@Dufgui
Copy link
Contributor Author

Dufgui commented Apr 26, 2021 •
edited
Loading

yes but i don't know how to reuse it, if i am not the author. I rebase the code and do what is asked in the other PR. Is it possible?

@Dufgui
Copy link
Contributor Author

Dufgui commented Apr 26, 2021

#134

@Dufgui Dufgui requested a review from michael-o April 26, 2021 19:45
@Dufgui Dufgui changed the title Mng 6294 [MNG-6294] - Convert MavenPluginValidator into a plexus component Apr 26, 2021
@Dufgui
Copy link
Contributor Author

Dufgui commented Apr 30, 2021

is it ok @michael-o ?

@michael-o
Copy link
Member

michael-o commented Apr 30, 2021

Its in my queue, I will try to process this weekend.

@cstamas cstamas changed the title [MNG-6294] - Convert MavenPluginValidator into a plexus component [MNG-6294] - Convert MavenPluginValidator into a JSR330 component Apr 30, 2021
@Dufgui
Copy link
Contributor Author

Dufgui commented Apr 30, 2021

thanks

@michael-o
Copy link
Member

michael-o commented May 2, 2021

Going through...

@michael-o
Copy link
Member

michael-o commented May 2, 2021

@rfscholte I'd like to merge this, as it looks fine to me. Regarding your concern: #134 (comment)
I do agree, but that is a different issue. The interface must be changed for a collector like in DefaultModelValidator, but I don't want to conflate two different things. So, if you don't object, I will run ITs and merge.

@msimacek @michael-o
[MNG-6294] Convert MavenPluginValidator into a JSR 330 component
990fb00 
Modified by: Guillaume Dufour <guillaume.duff@gmail.com>

This closes apache#134 and closes apache#470
@rfscholte
Copy link
Contributor

rfscholte commented May 2, 2021

By having an interface you start a contract, and I have my doubts about the method signature.
Can we move both classes to the internal package (and maybe reduce the visibility to package private) until there is a MavenPluginValidator signature we can agree on?

@michael-o
Copy link
Member

michael-o commented May 2, 2021

By having an interface you start a contract, and I have my doubts about the method signature.
Can we move both classes to the internal package (and maybe reduce the visibility to package private) until there is a MavenPluginValidator signature we can agree on?

I guess so. Let me try that.

@michael-o
Copy link
Member

michael-o commented May 2, 2021 •
edited
Loading

@rfscholte master...MNG-6294 Is that what you had in mind?

@asfgit asfgit closed this in 83e3664 May 3, 2021
@jira-importer
Copy link

jira-importer commented Jul 6, 2025

Resolve #7576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-o michael-o Awaiting requested review from michael-o

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Dufgui @michael-o @rfscholte @jira-importer @msimacek