[MNG-6268] When a reactor build fails Maven should include -f (if used) in command line suggestion #398
Conversation
…d) in command line suggestion
|
Writing a unittest is much easier in this case and sufficient enough. |
eolivelli
left a comment
There was a problem hiding this comment.
LGTM
I agree that a unit test is enough here
|
Just scratching my head how the full boostrap with a unit test would work here since I'd need to analyze stdout/err. |
|
IIRC @mthmulders had a similar usecase recently |
Not sure if I understand correctly what you refer to. I recently had a contribution to Plexus Archiver where I wrote a |
|
The SFL4J test looks promising, but wouldn't it be easier to do just an IT instead of going through a new component? |
|
Another option is to increase the visibility of |
|
Another option is to have no test at all since this change is straight forward. Pipe input to output unmodified as you can see. |
|
I'm fine with no test in this case. |
|
The issue has been closed as wontfix. So closing this, but leaving the branch for a while. |
Add additional cases as original test is not the full story. Make sure tree is same even if pushed down a level (in Maven3 is not) --- https://issues.apache.org/jira/browse/MNG-8347
|
Resolve #7601 |
I don't know whether this should be included, but it is trivial to provide. I will let the community decide. If accepted someone should write an IT for that.