Skip to content

[MNG-6957] Build/consumer should work with reverse module order in aggregator #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rfscholte wants to merge 105 commits into from
Closed

[MNG-6957] Build/consumer should work with reverse module order in aggregator #384

rfscholte wants to merge 105 commits into from

Conversation

@rfscholte
Copy link
Contributor

@rfscholte rfscholte commented Oct 15, 2020

No description provided.

rfscholte added 30 commits July 4, 2020 23:27
@rfscholte
[MNG-6952] Fail early if pom cannot be transformed
2e66809
@rfscholte
Merge branch 'master' of https://gitbox.apache.org/repos/asf/maven
f211600
@rfscholte
MNG-6957: extract inherit
65416f4
@rfscholte
MNG-6957: remove model from inherit method
92dbef3
@rfscholte
Simplify code
818a65f
@rfscholte
Get modules from fileModel, respect profiles (which can also contain …
7e72b8a 
…modules)
@rfscholte
Add activeExternalProfiles
81ecf11
@rfscholte
No need to check getActiveExternalProfiles, can't contain modules
c98ac84
@rfscholte
Moving up setters of result
964a429
@rfscholte
No need to keep activeProfiles in ModelData
2f56309
@rfscholte
result.setRawModel( modelId, rawModel ) can also be moved
bcc6eae
@rfscholte
lineage can just a Models
a9e49d6
@rfscholte
Replace ModelSource with Source
9999c34
@rfscholte
Make clear where rawModel and model should be used
5722189
@rfscholte
Use rawModel to read get parent
de2aa21
@rfscholte
pick up tmpModel from result
ef78edc
@rfscholte
extract profiles from result
3ac10de
@rfscholte
verify superpom by id
e3c31a0
@rfscholte
check currentData by id
2413ba1
@rfscholte
ModelData.rawModel is never used
e49508c
@rfscholte
pick up inherited model from lineage
fb6e610
@rfscholte
Don't update ModelData
b316883
@rfscholte
No need to change GAV for ModelData
56023c4
@rfscholte
checkPluginVersions must use lineage
c0abef8
@rfscholte
Split collecting raw models from inheritence
0f2ea38
@rfscholte
Set effectiveModel instance early
1760e4a
@rfscholte
start reading poms witout parent
ba6c0ce
@rfscholte
move effectivemodel to phase 2
6461714
@rfscholte
get activeExternalProfiles from result
5eff776
@rfscholte
in case of root, pick up effectivepom from result
fdbc758
rfscholte added 21 commits October 2, 2020 13:06
@rfscholte
No need to cache temp raw model during phase 1
5567276
@rfscholte
No need to reset getModelIds anymore
e3a0bb3
@rfscholte
Provide option key for transformerContext
609888f
@rfscholte
inline code
6ab0757
@rfscholte
rename to readEffectiveModel, so we have all readXModel available
3cadf52
@rfscholte
Remove pomFile parameter
2dabcb4
@rfscholte
prepare reading unknown dependency from build/consumer pom
4d00991
@rfscholte
Fix early dependency reactor read for build/consumer
65e8e74
@rfscholte
Fix buildconsumer for unknown parent
b37a89b
@rfscholte
This can stay ModelBuildingRequest
c194e51
@rfscholte
Remove redundant parameter of readFileModel
5152489
@rfscholte
remove redundant parameter from readRawModel
a715b1b
@rfscholte
Introduce DefaultTransformerContext, initialized during build, immuta…
fb13e32 
…ble during consume.
@rfscholte
Pass ModelBuildingRequest
61befeb
@rfscholte
Refactor code
d626493
@rfscholte
Update documentation
23736a1
@rfscholte
Add javadoc
9adea33
@rfscholte
Improve parentFilter, change requirement getRawModel by Path
11153cf
@rfscholte
Extract interface, only DefaultModelBuilder should be aware of implem…
63e6719 
…entation of TransformerContextBuilder
@rfscholte
improve documentation, make tags name similar
d3cfafd
@rfscholte
improve documentation
15bc6c7
@asfgit asfgit closed this Oct 27, 2020
@asfgit asfgit deleted the MNG-6957 branch October 27, 2020 11:13
@rfscholte rfscholte restored the MNG-6957 branch October 27, 2020 11:39
@rfscholte rfscholte reopened this Oct 27, 2020
@rfscholte
Copy link
Contributor Author

rfscholte commented Oct 27, 2020

I guess this was closed by accident...

@asfgit asfgit closed this Oct 27, 2020
@asfgit asfgit deleted the MNG-6957 branch October 27, 2020 20:41
gnodet added a commit to gnodet/maven that referenced this pull request Oct 27, 2024
@gnodet @DidierLoiseau
[MNG-8295] Add IT for Dependency Manager Transitivity (apache#384)
d98fe8e 
Co-authored-by: DidierLoiseau <didierloiseau+github@gmail.com>
@jira-importer
Copy link

jira-importer commented Jul 6, 2025

Resolve #8082

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rfscholte @jira-importer @asfgit