[MNG-5693] Change logging of MojoExceptions to console #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MojoExecutionException and MojoFailureException should never refer to a wikipage anymore.
eolivelli
requested changes
Jan 5, 2019
| } | ||
|
|
||
| return new ExceptionSummary( exception, message, reference, children ); | ||
| return new ExceptionSummary( exception, message, null, children ); |
Contributor
There was a problem hiding this comment.
Are we losing the exception at all?
Member
Author
There was a problem hiding this comment.
No, in reference we store shot exception name or links to cwiki
Contributor
There was a problem hiding this comment.
Got it
Why not dropping the field?
Contributor
There was a problem hiding this comment.
I think it should be possible for some Maven Exceptions to provide their own reference, so plugins and extensions can refer to their own documentation. This cleanup looks a bit too agressive to me.
gnodet
pushed a commit
to gnodet/maven
that referenced
this pull request
Nov 20, 2024
A parent POM have it removed, but the plgMgmt does not have this entry of IT project.
|
Resolve #6616 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.