Skip to content

Restore Jenkins build for master #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
olamy merged 51 commits into from
Mar 15, 2025
Merged

Restore Jenkins build for master #2151

olamy merged 51 commits into from
Mar 15, 2025

Conversation

@olamy
Copy link
Member

@olamy olamy commented Mar 8, 2025

  • Revert "Disable Jenkins temporarily"
  • use maven3
  • versionlessMavenDist profile is failing test
  • fix ITs branch
  • cannot run embedded ITs with maven4
  • use mvnw
  • use mvnw
  • fix build of temporary distro
  • fix build of temporary distro
  • use -PversionlessMavenDist for its
  • test if distro really here
  • test if distro really here

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

cstamas
cstamas reviewed Mar 8, 2025
View reviewed changes
cstamas
cstamas reviewed Mar 8, 2025
View reviewed changes
@olamy olamy force-pushed the master-jenkinsfile branch from 65d29ba to 8bc0eb2 Compare March 12, 2025 03:52
@olamy olamy marked this pull request as ready for review March 14, 2025 23:39
olamy added 26 commits March 15, 2025 10:06
@olamy
Revert "Disable Jenkins temporarily"
feeda72 
This reverts commit be6a535.
@olamy
use maven3
b4a232d 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
versionlessMavenDist profile is failing test
a7a9d94 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix ITs branch
d248d77 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
cannot run embedded ITs with maven4
9a3fd89 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
use mvnw
be74e95 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
use mvnw
6993c69 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix build of temporary distro
170e5d9 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix build of temporary distro
cbb3e36 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
use -PversionlessMavenDist for its
ec2d612 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
test if distro really here
4326586 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
test if distro really here
a385c1a 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
do not use -DmavenDistro=
dda3100 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
some debug
1386e3b 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
some debug
60741d8 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
more history
555aebf 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
simplify jenkinsfile
6bb28b4 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix label
212b98c 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix label
2175b64 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix label
a345268 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
use env.WORKSPACE
fb68ea8 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix mvn version
5b8fe9d 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
rat check exclude Jenkinsfile
e091ac0 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
add debug
8160680 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
use env.WORKSPACE
bfa21d8 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
add coverage report
129c4b1 
Signed-off-by: Olivier Lamy <olamy@apache.org>
olamy added 19 commits March 15, 2025 10:06
@olamy
fix deploy
3ec6c10 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
cannot deploy in one go
8bc175b 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
use -B
ebe03ed 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
deploy only for master branch
ab76d6d 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
not too far test result parsing
c36a75e 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
use dedicated surefire report directory to have different one fron its
6fa53ce 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix jacoco argLine
6a47642 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix jacoco argLine
9db1a52 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix jacoco argLine
4147fe0 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
get jacoco data when running its
c300d15 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
jacoco exclude its sources
cd12cb9 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
remove comments
bddb12c 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
a bit more memory for jacoco
8e427cb 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
aggregate jacoco
574d7c1 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix declaration
057927f 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
coverage only for 21
91e2604 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
use different file for jacoco its data
e2b7140 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
jacoco is just too slow for ITs
d511010 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
fix comment
302e8a9 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy force-pushed the master-jenkinsfile branch from a641db3 to 302e8a9 Compare March 15, 2025 00:06
olamy
olamy commented Mar 15, 2025
View reviewed changes
...port/maven-it-helper/src/main/java/org/apache/maven/it/AbstractMavenIntegrationTestCase.java
protected Verifier newVerifier(String basedir, String settings, boolean debug) throws VerificationException {
Verifier verifier = new Verifier(basedir);

// try to get jacoco arg from command line if any then use it to start IT to populate jacoco data
Copy link
Member Author

@olamy olamy Mar 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just leave it but it's not activated in the build as it's definitely too slow.

@olamy
fix alternate surefire report location
b979c39 
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy merged commit 199ed20 into master Mar 15, 2025
19 checks passed
@olamy olamy deleted the master-jenkinsfile branch March 15, 2025 08:48
@github-actions github-actions bot added this to the 4.0.0-rc-4 milestone Mar 15, 2025
cstamas pushed a commit to cstamas/maven that referenced this pull request Mar 19, 2025
@olamy @cstamas
Restore Jenkins build for master (apache#2151)
4e2b82e 
* Restore Jenkinsfile

Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy added build Pull requests that change the build process and removed maintenance labels Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cstamas cstamas cstamas left review comments

Assignees

@olamy olamy

Labels

build Pull requests that change the build process

Projects

None yet

Milestone

4.0.0-rc-4

Development

Successfully merging this pull request may close these issues.

2 participants

@olamy @cstamas