Skip to content

Conversation

@laeubi
Copy link
Contributor

@laeubi laeubi commented Oct 20, 2025

(fixes #11299)

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@gnodet
Copy link
Contributor

gnodet commented Oct 23, 2025

@laeubi additional dependencies should be added to the graph so that they end up in the generated graph.

@laeubi
Copy link
Contributor Author

laeubi commented Oct 23, 2025

Okay I need to look into this, if you think its easier for you to do it directly I would be fine with it I think it is quite clear what I try to accomplish here?

@gnodet gnodet added bug Something isn't working backport-to-4.0.x labels Oct 23, 2025
@gnodet gnodet added this to the 4.1.0 milestone Oct 23, 2025
@gnodet
Copy link
Contributor

gnodet commented Oct 24, 2025

It seems one IT constantly fail on windows

@gnodet gnodet requested a review from cstamas October 27, 2025 09:34
@gnodet gnodet merged commit 151d576 into apache:master Oct 27, 2025
37 of 38 checks passed
gnodet added a commit to gnodet/maven that referenced this pull request Oct 27, 2025
* Add backward compatibility dependencies to maven-compat

(fixes apache#11299)

* Add aopalliance to sisu box

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Guillaume Nodet <gnodet@gmail.com>
(cherry picked from commit 151d576)
@gnodet
Copy link
Contributor

gnodet commented Oct 27, 2025

💚 All backports created successfully

Status Branch Result
maven-4.0.x

Questions ?

Please refer to the Backport tool documentation

gnodet added a commit that referenced this pull request Oct 27, 2025
)

* Add backward compatibility dependencies to maven-compat

(fixes #11299)

* Add aopalliance to sisu box

---------



(cherry picked from commit 151d576)

Co-authored-by: Christoph Läubrich <mail@laeubi-soft.de>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-4.0.x bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[back compat] Add previous compile dependencies that are now missing

2 participants