Fix dependency groupId inference for Maven 4.1.0 model version #11228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issue apache#11135 where dependencies with missing groupId but present version were not having their groupId inferred from the project groupId in Maven 4.1.0 model version. The issue was that the groupId inference logic was only triggered when both groupId and version were missing (in the inferDependencyVersion method). However, the issue described cases where dependencies had versions but missing groupIds. Changes made: 1. Modified transformFileToRaw method in DefaultModelBuilder to handle missing groupId cases separately from missing version cases 2. Added new inferDependencyGroupId method that specifically handles groupId inference when version is present 3. Added unit test to verify the fix works correctly The fix ensures that for Maven 4.1.0 model version, dependencies with missing groupId will have their groupId inferred from the project groupId, regardless of whether the version is present or not. Fixes apache#11135
4edda4a to
b09b04c
Compare
cstamas
approved these changes
Oct 9, 2025
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Oct 9, 2025
…e#11228) This commit fixes issue apache#11135 where dependencies with missing groupId but present version were not having their groupId inferred from the project groupId in Maven 4.1.0 model version. The issue was that the groupId inference logic was only triggered when both groupId and version were missing (in the inferDependencyVersion method). However, the issue described cases where dependencies had versions but missing groupIds. Changes made: 1. Modified transformFileToRaw method in DefaultModelBuilder to handle missing groupId cases separately from missing version cases 2. Added new inferDependencyGroupId method that specifically handles groupId inference when version is present 3. Added unit test to verify the fix works correctly The fix ensures that for Maven 4.1.0 model version, dependencies with missing groupId will have their groupId inferred from the project groupId, regardless of whether the version is present or not. Fixes apache#11135 (cherry picked from commit d4336c6)
gnodet
added a commit
that referenced
this pull request
Oct 9, 2025
… (#11240) This commit fixes issue #11135 where dependencies with missing groupId but present version were not having their groupId inferred from the project groupId in Maven 4.1.0 model version. The issue was that the groupId inference logic was only triggered when both groupId and version were missing (in the inferDependencyVersion method). However, the issue described cases where dependencies had versions but missing groupIds. Changes made: 1. Modified transformFileToRaw method in DefaultModelBuilder to handle missing groupId cases separately from missing version cases 2. Added new inferDependencyGroupId method that specifically handles groupId inference when version is present 3. Added unit test to verify the fix works correctly The fix ensures that for Maven 4.1.0 model version, dependencies with missing groupId will have their groupId inferred from the project groupId, regardless of whether the version is present or not. Fixes #11135 (cherry picked from commit d4336c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes issue #11135 where dependencies with missing groupId but present version were not having their groupId inferred from the project groupId in Maven 4.1.0 model version.
The issue was that the groupId inference logic was only triggered when both groupId and version were missing (in the inferDependencyVersion method). However, the issue described cases where dependencies had versions but missing groupIds.
Changes made:
The fix ensures that for Maven 4.1.0 model version, dependencies with missing groupId will have their groupId inferred from the project groupId, regardless of whether the version is present or not.
Fixes #11135