Skip to content

[3.9.x][MNG-7587] Upgrade to sisu 0.9.0.M2#1121

Merged
gnodet merged 1 commit intoapache:maven-3.9.xfrom
gnodet:MNG-7587-3.9.x
May 31, 2023
Merged

[3.9.x][MNG-7587] Upgrade to sisu 0.9.0.M2#1121
gnodet merged 1 commit intoapache:maven-3.9.xfrom
gnodet:MNG-7587-3.9.x

Conversation

@gnodet
Copy link
Copy Markdown
Contributor

@gnodet gnodet commented May 24, 2023

@gnodet gnodet marked this pull request as ready for review May 24, 2023 08:36
@gnodet gnodet changed the title [MNG-7587] Upgrade to sisu 0.9.0.M2 [3.9.x][MNG-7587] Upgrade to sisu 0.9.0.M2 May 24, 2023
@cstamas
Copy link
Copy Markdown
Member

cstamas commented May 24, 2023

What about:

  • using sisu "no_asm" classifier
  • using guice "classes" classifier
  • declaring asm (whatever version, for start 9.5) as maven dep?

@kwin
Copy link
Copy Markdown
Member

kwin commented May 24, 2023

What about:

using sisu "no_asm" classifier
using guice "classes" classifier
declaring asm (whatever version, for start 9.5) as maven dep?

I would defer to add this additional complexity until there is a new version of ASM released which is not (yet) integrated in Sisu.

@gnodet
Copy link
Copy Markdown
Contributor Author

gnodet commented May 24, 2023

What about:

using sisu "no_asm" classifier
using guice "classes" classifier
declaring asm (whatever version, for start 9.5) as maven dep?

I would defer to add this additional complexity until there is a new version of ASM released which is not (yet) integrated in Sisu.

We can't defer if we want JDK 17 support. We use juice 5.1.0 which embeds asm 9.2, so we need to use version which does not embed asm. We can do that for 4.x only though...

Copy link
Copy Markdown
Member

@cstamas cstamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 3.9.x "simple upgrade" is the way to go, and let's do the "asm trick" on master

@gnodet
Copy link
Copy Markdown
Contributor Author

gnodet commented May 24, 2023

I've pushed the

For 3.9.x "simple upgrade" is the way to go, and let's do the "asm trick" on master

This should provide support to at least JDK 18.

@gnodet gnodet merged commit 27caa8c into apache:maven-3.9.x May 31, 2023
gnodet added a commit that referenced this pull request Jun 2, 2023
@jira-importer
Copy link
Copy Markdown

Resolve #8936

@olamy olamy mentioned this pull request Apr 2, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants