Bug: bad cache isolation between two sessions #11083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port of Maven 3 bugfix to Maven 4 (deprecatd) `maven-embedder` module. Maven 4 by default is **not affected**, but this PR aligns Maven 3 and deprecated module in Maven 4. The "early" session used to load extension will populate cache in MavenExecutionRequest and same cache is later reused in "normal" session as well. This is wrong, as if project uses same parent POM as any of loaded extnsions, data loss in form of lost input locations occurs. Fixes apache#11081
cstamas
added a commit
to cstamas/maven
that referenced
this pull request
Sep 1, 2025
Port of Maven 3 bugfix to Maven 4 (deprecatd) `maven-embedder` module. Maven 4 by default is **not affected**, but this PR aligns Maven 3 and deprecated module in Maven 4. The "early" session used to load extension will populate cache in MavenExecutionRequest and same cache is later reused in "normal" session as well. This is wrong, as if project uses same parent POM as any of loaded extnsions, data loss in form of lost input locations occurs. Fixes apache#11081
cstamas
added a commit
that referenced
this pull request
Sep 1, 2025
Port of Maven 3 bugfix to Maven 4 (deprecatd) `maven-embedder` module. Maven 4 by default is **not affected**, but this PR aligns Maven 3 and deprecated module in Maven 4. The "early" session used to load extension will populate cache in MavenExecutionRequest and same cache is later reused in "normal" session as well. This is wrong, as if project uses same parent POM as any of loaded extnsions, data loss in form of lost input locations occurs. Fixes #11081
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of Maven 3 bugfix to Maven 4 (deprecated)
maven-embeddermodule. Maven 4 by default is not affected, but this PR aligns Maven 3 and deprecatedmaven-embeddermodule in Maven 4.The "early" session used to load extension will populate cache in MavenExecutionRequest and same cache is later reused in "normal" session as well.
This is wrong, as if project uses same parent POM as any of loaded extnsions, data loss in form of lost input locations occurs.
Fixes #11081