Simplify prefix resolution #11072
Merged
Simplify prefix resolution #11072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First proposal, that is nearly trivial, just collect plugin groupIDs to check in proper order. There may be tricks for plugins lacking G metadata...
gnodet
approved these changes
Aug 28, 2025
cstamas
added a commit
to cstamas/maven
that referenced
this pull request
Aug 28, 2025
Simplify prefix resolution and drop use of BuildPluginManager (as descriptor will be re-resolved again later) and focus only on prefix to GA resolution, using a map of rules: * collect POM enlisted plugin groupId:artifactId pairs that come from non-settings-enlisted groupIDs (and allow only enlisted artifactIDs) * add settings enlisted plugin groupIds (keep their order) but "allow any" artifactId Using this map, figure out plugin GA from prefix using Maven metadata only. Fixes apache#11067 Backport of 2b7bb9c
cstamas
added a commit
that referenced
this pull request
Aug 28, 2025
Simplify prefix resolution and drop use of BuildPluginManager (as descriptor will be re-resolved again later) and focus only on prefix to GA resolution, using a map of rules: * collect POM enlisted plugin groupId:artifactId pairs that come from non-settings-enlisted groupIDs (and allow only enlisted artifactIDs) * add settings enlisted plugin groupIds (keep their order) but "allow any" artifactId Using this map, figure out plugin GA from prefix using Maven metadata only. Fixes #11067 Backport of 2b7bb9c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify prefix resolution and drop use of BuildPluginManager (as descriptor will be re-resolved again later) and focus only on prefix to GA resolution, using a map of rules:
Using this map, figure out plugin GA from prefix using Maven metadata only.
Fixes #11067