-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Fix targetPath parameter ignored in resource bundles (fixes #11062) #11063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gnodet
merged 8 commits into
apache:master
from
mbaurin:fix/maven-4-targetpath-resource-bundle-ignored
Aug 29, 2025
Merged
Fix targetPath parameter ignored in resource bundles (fixes #11062) #11063
gnodet
merged 8 commits into
apache:master
from
mbaurin:fix/maven-4-targetpath-resource-bundle-ignored
Aug 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@mbaurin thank, please also adjust tests as you describe |
Contributor
Author
done ✅ @slawekjaranowski |
gnodet
approved these changes
Aug 27, 2025
a1760ab to
f4fa892
Compare
cstamas
approved these changes
Aug 28, 2025
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Aug 29, 2025
) (apache#11063) Co-authored-by: Guillaume Nodet <gnodet@gmail.com> (cherry picked from commit e4579e9)
Contributor
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this checklist to help us incorporate your
contribution quickly and easily:
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.
Summary
Fixes the regression where
targetPathparameter in<resources>and<testResources>was being ignored in Maven 4.0.0-rc-4, causing resources to be copied to incorrect locations.Root Cause
The issue was introduced in commit
0d7b61a4b4with the newConnectedResourceimplementation, which had three critical bugs that causedtargetPathto be lost during resource processing.Changes Made
Fixed ConnectedResource constructor (
ConnectedResource.java:44).targetPath()to Resource.newBuilder() chainsourceRoot.targetPath().map(path -> path.toString()).orElse(null)Fixed DefaultSourceRoot constructor (
DefaultSourceRoot.java:120-121)targetPath = nullwith proper Resource extractionvalue = nonBlank(resource.getTargetPath()); targetPath = (value != null) ? baseDir.resolve(value) : null;Fixed MavenProject.toResource method (
MavenProject.java:831)Test Plan
PomConstructionTestvalidate targetPath functionality and continue to passcomplete-modeltest resources contain targetPath examples that validate the fixBackwards Compatibility
This fix restores full backwards compatibility with Maven 3.x behavior while preserving all ConnectedResource improvements introduced in rc-4.
Fixes #11062