LUCENE-9652: DataInput.readFloats for use by Lucene90VectorReader#2175
Merged
msokolov merged 3 commits intoapache:masterfrom Jan 6, 2021
Merged
LUCENE-9652: DataInput.readFloats for use by Lucene90VectorReader#2175msokolov merged 3 commits intoapache:masterfrom
msokolov merged 3 commits intoapache:masterfrom
Conversation
Contributor
|
IMHO, as this is little endian, we should name the new method like the long one. |
Contributor
Author
Fair enough; I'll post an update soon. |
Contributor
Author
|
I plan to push soon - @uschindler do you have any further comments? |
uschindler
pushed a commit
to uschindler/lucene-solr
that referenced
this pull request
Jan 6, 2021
uschindler
added a commit
to uschindler/lucene-solr
that referenced
this pull request
Jan 6, 2021
ctargett
pushed a commit
to ctargett/lucene-solr
that referenced
this pull request
Jan 11, 2021
epugh
pushed a commit
to epugh/lucene-solr-1
that referenced
this pull request
Jan 15, 2021
ctargett
pushed a commit
that referenced
this pull request
Jan 15, 2021
gsmiller
pushed a commit
to gsmiller/lucene-solr
that referenced
this pull request
Mar 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
DataInput.readFloatsand makes use of it inLucene90VectorReader. The implementation and tests are essentially cloned fromreadLELongs. With these changes I observed definite speedups, although not as much as I expected from microbenchmarking. There's a fair amount of variability, but I see at least 20%, sometimes as much as 40% reduction in time for HnswGraph.search, as measured by KnnGraphTester.