Detect CI builds and enable errorprone by default for those CI builds#890
Merged
uschindler merged 3 commits intoapache:mainfrom May 14, 2022
Merged
Detect CI builds and enable errorprone by default for those CI builds#890uschindler merged 3 commits intoapache:mainfrom
uschindler merged 3 commits intoapache:mainfrom
Conversation
…ally enable it with -Perrorprone.enabled=true
191cc82 to
c082464
Compare
uschindler
commented
May 14, 2022
Contributor
Author
|
I renamed the project property to "validation.errorprone" to be in line with other optional checks (like owasp). Maybe we should run owasp checker also automatically in CI mode? |
aea820d to
36cadf4
Compare
Contributor
Author
|
The owasp check currently fails because of vulns in Jetty. We should upgrade (that's a separate task). |
mocobeta
reviewed
May 15, 2022
dweiss
reviewed
May 16, 2022
Contributor
dweiss
left a comment
There was a problem hiding this comment.
Yup, that's nicer (property name).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This detects CI builds (Github and Jenkins) using existence of some environment variables. There is a new ext property
project.ext.isCIBuild.The ext property is used to enable errorprone on thse builds. You can still enable just errorprone on local builds with:
-Perrorprone.enabled=trueWe can use the new project property to enable other expensive checks by default for CI builds.