LUCENE-10242: The TopScoreDocCollector::createSharedManager should use ScoreDoc instead of FieldDoc#450
Merged
jpountz merged 1 commit intoapache:mainfrom Nov 18, 2021
Merged
Conversation
…e ScoreDoc instead of FieldDoc Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
jpountz
approved these changes
Nov 18, 2021
jpountz
pushed a commit
that referenced
this pull request
Nov 18, 2021
…e ScoreDoc instead of FieldDoc (#450) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Member
Author
|
Thank you @jpountz ! |
jpountz
pushed a commit
that referenced
this pull request
Nov 18, 2021
…e ScoreDoc instead of FieldDoc (#450) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Redko andriy.redko@aiven.io
Description
The
TopScoreDocCollector::createSharedManagershould useScoreDocinstead ofFieldDocas a type ofafterargument. TheFieldDocis really needed only in case ofTopFieldCollectorbut now its usage is mandated byTopScoreDocCollectorand leads to unnecessary conversion tricks.Solution
Relax
afterargument type fromFieldDoctoScoreDocTests
The functionality is covered by existing tests. Since
FieldDocis a subclass ofScoreDoc, the change is fully compatible and non breaking.Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.