LUCENE-9861: pull tuned vm options into a separate aspect.#33
LUCENE-9861: pull tuned vm options into a separate aspect.#33dweiss merged 1 commit intoapache:mainfrom
Conversation
uschindler
left a comment
There was a problem hiding this comment.
Looks like a generic way to handle this.
IMHO, the RenderJavadoc tasks should maybe extend JavaExec anyways.
| args += [ "-enableJavadoc" ] | ||
| args += [ "-properties", file("${resources}/ecj.javadocs.prefs").absolutePath ] | ||
|
|
||
| // disable for now because individual file excludes cannot be applied to ecj. |
There was a problem hiding this comment.
can we apply the options here as well, like the patch on the JIRA? It was a large win for ecjlint for me.
There was a problem hiding this comment.
nm, i see, it must be a "JavaExec" ?
There was a problem hiding this comment.
It is. That's the trick here. 😜
There was a problem hiding this comment.
These vm options are applied to all ecjLint* tasks - I just moved the application to that separate file.
There was a problem hiding this comment.
In addition, it's automatically activated for all JavaExec tasks, no need to handle it in all custom tasks.
|
I compared times with another PR (just looking at the github check times), and it shaved a few minutes off |
No description provided.