Shrink FuzzySet public API surface area#14615
Conversation
af6f6b1 to
7d809b0
Compare
7d809b0 to
e3ded15
Compare
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
|
I was looking at Lucene's bloom filter codec again today for another reason, and was reminded of this open PR. I still think it would be nice to shrink the API surface area here. Curious if anyone has thoughts? |
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
For what it's worth, I am onboard. Always nice to shrink the API surface area if we can. If someone wants a general-purpose Bloom filter in Java with all the bells and whistles, they can just use Guava. (As is, what's left of FuzzySet is a pretty useful Bloom filter.) |
|
Thanks @msfroh for your thoughts on this! I'll dust this back off and plan to merge it tomorrow if nobody else has objections. I think it's worth tightening this up. |
Removes public methods with no current library usage that we probably don't want to publicly maintain
e3ded15 to
9491a2f
Compare
Description
Proposal to remove some public APIs we don't use internally anymore and likely don't want to maintain for public consumption. (Would back port with deprecation notices if the community agrees with this)