Skip to content

removing constructor with deprecated attribute 'onlyLongestMatch#14356

Merged
rmuir merged 2 commits intoapache:mainfrom
renatoh:cleanUpDeprecatedonlyLongestMatchInDitionnaryCompoundWordTokenFilterr
May 10, 2025
Merged

removing constructor with deprecated attribute 'onlyLongestMatch#14356
rmuir merged 2 commits intoapache:mainfrom
renatoh:cleanUpDeprecatedonlyLongestMatchInDitionnaryCompoundWordTokenFilterr

Conversation

@renatoh
Copy link
Contributor

@renatoh renatoh commented Mar 14, 2025

Description

if (onlyLongestMatch)
LOG.warning(
"onlyLongestMatch has been removed and replaced by onlyLongestMatchIgnoreSubwords");

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmuir Does this check make sense?

@renatoh
Copy link
Contributor Author

renatoh commented Mar 28, 2025

@rmuir Please have a look at it when you have the chance. thanks

@github-actions
Copy link
Contributor

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

@github-actions github-actions bot added the Stale label Apr 12, 2025
@renatoh
Copy link
Contributor Author

renatoh commented Apr 24, 2025

@rmuir Could you please have a look at the PR, it has been open for more than a month. Thanks

@github-actions github-actions bot removed the Stale label Apr 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution!

@github-actions github-actions bot added the Stale label May 9, 2025
@rmuir rmuir merged commit ebc6350 into apache:main May 10, 2025
8 checks passed
@rmuir
Copy link
Member

rmuir commented May 10, 2025

Thank you @renatoh !

weizijun added a commit to weizijun/lucene that referenced this pull request May 16, 2025
* main: (31 commits)
  Fix termination condition in TestStressNRTReplication. (apache#14665)
  deps(java): bump com.gradle.develocity from 3.19 to 3.19.2 (apache#14662)
  Build: remove hard-coded Java versions from ecj.javadocs.prefs (apache#14651)
  Update verifier comment to show label (apache#14658)
  Catch and re-throw Throwable rather than using a success boolean (apache#14633)
  Mention label in changelog verifier comment (apache#14656)
  Enable PR actions in changelog verifier (apache#14644)
  Fix FuzzySet#getEstimatedNumberUniqueValuesAllowingForCollisions to properly account for hashCount (apache#14614)
  Don't perform additional KNN querying after timeout, fixes apache#14639 (apache#14640)
  Add instructions to help/IDEs.txt for VSCode and Neovim (apache#14646)
  build(deps): bump ruff from 0.11.7 to 0.11.8 in /dev-tools/scripts (apache#14603)
  deps(java): bump de.jflex:jflex from 1.8.2 to 1.9.1 (apache#14583)
  Use the preload hint on completion fields and memory terms dictionaries. (apache#14634)
  Clean up FileTypeHint a bit. (apache#14635)
  Expressions: Improve test to use a fully private class or method
  Remove deprecations in expressions (apache#14641)
  removing constructor with deprecated attribute 'onlyLongestMatch (apache#14356)
  Moving CHANGES entry for apache#14609 from 11.0 to 10.3 (apache#14638)
  Overrides rewrite in PointRangeQuery to optimize AllDocs/NoDocs cases (apache#14609)
  Adding benchmark for histogram collector over point range query (apache#14622)
  ...

# Conflicts:
#	lucene/CHANGES.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants