ToParentBlockJoin[Byte|Float]KnnVectorQuery needs to handle the case when parents are missing#12504
Merged
benwtrent merged 1 commit intoapache:mainfrom Aug 14, 2023
Conversation
…when parents are missing
romseygeek
approved these changes
Aug 14, 2023
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
LGTM. Returning 0 hits in these cases is what we do in ToParentBlockJoinQuery so it makes sense to me to behave consistently here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to: #12434
Adds a test for when parents are missing in the index and verifies we return no hits. Previously this would have thrown an NPE
Doesn't really justify a CHANGES update as its fixing an unreleased bug due to this previous change.