Fix failure in BaseKnnVectorsFormatTestCase#testIllegalDimensionTooLarge#12467
Merged
mayya-sharipova merged 1 commit intoapache:mainfrom Jul 28, 2023
Merged
Conversation
…ensionTooLarge Depending whether a document with dimensions > maxDims created on a new segment or already existing segment, we may get different error messages. This fix adds another possible error message we may get. Relates to apache#12436
benwtrent
approved these changes
Jul 28, 2023
Member
benwtrent
left a comment
There was a problem hiding this comment.
ran the failing test with thousands of seeds and with the REPRODUCE line:
./gradlew test --tests TestLucene94HnswVectorsFormat.testIllegalDimensionTooLarge -Dtests.seed=AC72FE56C18F6C82 -Dtests.nightly=true -Dtests.locale=sg-CF -Dtests.timezone=America/St_Thomas -Dtests.asserts=true -Dtests.file.encoding=UTF-8
Everything is 🟢 . 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depending whether a document with dimensions > maxDims created on a new segment or already existing segment, we may get different error messages. This fix adds another possible error message we may get.
Relates to #12436