Fix algorithm that chooses the bridge between a polygon and a hole#11988
Merged
iverase merged 4 commits intoapache:mainfrom Dec 13, 2022
Merged
Fix algorithm that chooses the bridge between a polygon and a hole#11988iverase merged 4 commits intoapache:mainfrom
iverase merged 4 commits intoapache:mainfrom
Conversation
# Conflicts: # lucene/CHANGES.txt
iverase
added a commit
that referenced
this pull request
Dec 13, 2022
…11988) # Conflicts: # lucene/CHANGES.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current algorithm seems to fail when the bridge is located on the first node of the iteration and there are another vertex with the same x and y. In that case we seem not to be able to find the right node because we actually never compute the tangent of the first node.
This change changes the iteration to make sure we compute the tangent for all nodes of the polygon which seems to help finding always the right bridge. We remove some logic we (well, it was me) added to try to fix this issue.
fixes #11986