Skip to content

Fix warning when last argument is null (#3975)#4014

Merged
ppkarwasz merged 1 commit intoapache:2.xfrom
lrozenblyum:fix/2.x/logging-with-null-throwable-warning
Dec 29, 2025
Merged

Fix warning when last argument is null (#3975)#4014
ppkarwasz merged 1 commit intoapache:2.xfrom
lrozenblyum:fix/2.x/logging-with-null-throwable-warning

Conversation

@lrozenblyum
Copy link
Copy Markdown
Contributor

Allow extra null argument to ParameterFormatter without issuing a warning.

Fixes #3975

@github-project-automation github-project-automation bot moved this to Changes requested in Log4j pull request tracker Dec 28, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 28, 2025

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 Build Scan PUBLISHED
Generated by gradle/develocity-actions

@lrozenblyum lrozenblyum force-pushed the fix/2.x/logging-with-null-throwable-warning branch from fd0eb93 to 4bcd365 Compare December 29, 2025 07:28
Copy link
Copy Markdown
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@github-project-automation github-project-automation bot moved this from Changes requested to Approved in Log4j pull request tracker Dec 29, 2025
@ppkarwasz ppkarwasz merged commit 33fff89 into apache:2.x Dec 29, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Log4j pull request tracker Dec 29, 2025
@lrozenblyum
Copy link
Copy Markdown
Contributor Author

Thank you for fast review @ppkarwasz!

@lrozenblyum lrozenblyum deleted the fix/2.x/logging-with-null-throwable-warning branch December 29, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Logging with last implicit param a null Throwable generates framework warning

2 participants