Add useFqdn attribute to RFC5424 Layout#2853
Merged
Conversation
vy
reviewed
Aug 26, 2024
log4j-core/src/main/java/org/apache/logging/log4j/core/util/NetUtils.java
Outdated
Show resolved
Hide resolved
log4j-core/src/main/java/org/apache/logging/log4j/core/layout/Rfc5424Layout.java
Outdated
Show resolved
Hide resolved
vy
approved these changes
Aug 26, 2024
Since RFC5424 specifies that the [`HOSTNAME`](https://datatracker.ietf.org/doc/html/rfc5424#section-6.2.4) field should contain the FQDN of the current host, we replace replace the usage of `InetAddress.getHostName()` with `InetAddress.getCanonicalHostName()`. Closes #1740.
082f368 to
b593be7
Compare
ppkarwasz
added a commit
that referenced
this pull request
Sep 1, 2024
Since RFC5424 specifies that the [`HOSTNAME`](https://datatracker.ietf.org/doc/html/rfc5424#section-6.2.4) field should contain the FQDN of the current host, we replace replace the usage of `InetAddress.getHostName()` with `InetAddress.getCanonicalHostName()`. Closes #1740.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since RFC5424 specifies that the
HOSTNAMEfield should contain the FQDN of the current host, we add auseFqdnconfiguration attribute to RFC5424 Layout that replaces the usage ofInetAddress.getHostName()withInetAddress.getCanonicalHostName().Closes #1740.