Remove log4j-kubernetes in version 3.x
#2408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgoers
approved these changes
Mar 25, 2024
Member
rgoers
left a comment
There was a problem hiding this comment.
This looks good to me. Should it be dropped in 2.x as well?
Contributor
Author
I guess we can also drop it from 2.x. |
Member
|
+1 for dropping it from |
Contributor
Author
ppkarwasz
added a commit
that referenced
this pull request
Mar 26, 2024
Due to differences in the lifecycle of Log4j Core and Kubernetes Client, we remove `log4j-kubernetes` from the 3.x release and redirect users to Fabric8's own `kubernetes-log4j` artifact introduced in fabric8io/kubernetes-client#5718. The `log4j-kubernetes` lookup depends on: * the very stable `StrLookup` interface from Log4j Core, * the evolving set of Kubernetes metadata provided by Kubernetes Client. Therefore it makes more sense to distribute the lookup together with Kubernetes Client.
e9525d4 to
e62988b
Compare
Contributor
Author
|
Closes #2218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to differences in the lifecycle of Log4j Core and Kubernetes Client, we remove
log4j-kubernetesfrom the 3.x release and redirect users to Fabric8's ownkubernetes-log4jartifact introduced in version 6.11.0.Motivation
The
log4j-kuberneteslookup depends on:StrLookupinterface from Log4j Core,Therefore it makes more sense to distribute the lookup together with Kubernetes Client.