Closed
Conversation
Closed
Member
Author
|
Semms downgrading ClickHouse Server version breaks some metadata queries ... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6915 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 688 688
Lines 42590 42590
Branches 5805 5805
======================================
Misses 42590 42590 ☔ View full report in Codecov by Sentry. |
Member
Author
|
Pin |
lsm1
approved these changes
Feb 14, 2025
pan3793
added a commit
that referenced
this pull request
Feb 14, 2025
### Why are the changes needed? I observed ClickHouse integration test failure in GHA, after some investigation, the root cause is testcontainers/testcontainers-java#9942 ``` /entrypoint.sh: neither CLICKHOUSE_USER nor CLICKHOUSE_PASSWORD is set, disabling network access for user 'default' ``` In short, the recent ClickHouse docker image does not allow the `default` user to connect without a password, unfortunately, `testcontainers-scala-clickhosue` does not expose API to set CLICKHOSUE_USER and CLICKHOUSE_PASSWORD, as a workaround, I pin `clickhouse-server:24.3.15`(the latest version has no such restriction) until a fixed version of Testcontainers available. This PR also switches the `clickhouse-jdbc`'s classifier from `http` to `shaded`, the reason is, `http` does not ship ApacheHttpClient5, previously, it happened to work because `iceberg-runtime-spark3.5_2.12` packaged un-relocated ApacheHttpClient5 classes, but it gets fixed in Iceberg 1.8.0, then `clickhouse-jdbc:http` stop working. ``` java.lang.NoClassDefFoundError: org/apache/hc/core5/http/HttpRequest ``` Additionally, this PR bumps `clickhouse-jdbc` from 0.6.0 to 0.6.5. ### How was this patch tested? Pass GHA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #6915 from pan3793/fix-ch-test. Closes #6915 996f095 [Cheng Pan] Pin clickhouse-server:24.3.15 d633df0 [Cheng Pan] Bump clickhouse-jdbc 0.6.5 214c8a2 [Cheng Pan] Fix ClickHouse integration tests Authored-by: Cheng Pan <chengpan@apache.org> Signed-off-by: Cheng Pan <chengpan@apache.org> (cherry picked from commit d49c631) Signed-off-by: Cheng Pan <chengpan@apache.org>
Member
Author
|
Thanks, merged to master/1.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
I observed ClickHouse integration test failure in GHA, after some investigation, the root cause is testcontainers/testcontainers-java#9942
In short, the recent ClickHouse docker image does not allow the
defaultuser to connect without a password, unfortunately,testcontainers-scala-clickhosuedoes not expose API to set CLICKHOSUE_USER and CLICKHOUSE_PASSWORD, as a workaround, I pinclickhouse-server:24.3.15(the latest version has no such restriction) until a fixed version of Testcontainers available.This PR also switches the
clickhouse-jdbc's classifier fromhttptoshaded, the reason is,httpdoes not ship ApacheHttpClient5, previously, it happened to work becauseiceberg-runtime-spark3.5_2.12packaged un-relocated ApacheHttpClient5 classes, but it gets fixed in Iceberg 1.8.0, thenclickhouse-jdbc:httpstop working.Additionally, this PR bumps
clickhouse-jdbcfrom 0.6.0 to 0.6.5.How was this patch tested?
Pass GHA.
Was this patch authored or co-authored using generative AI tooling?
No.