Use CLUSTERX command to set cluster topology #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-hulk
approved these changes
Jul 12, 2021
Merged
ShooterIT
added a commit
to ShooterIT/kvrocks
that referenced
this pull request
Jul 15, 2021
Currently, we use cluster command to set cluster topology, as we know, we must allow users use cluster command to get nodes and slots, and we only can rename command name instead of subcommand, that is to say, users have a chance to change cluster topology, it is dangerous. Now, we use CLUSTERX command to set cluster topology, you can rename it if you don't want to expose this command to users.
Merged
ShooterIT
added a commit
that referenced
this pull request
Jul 19, 2021
Currently, we use cluster command to set cluster topology, as we know, we must allow users use cluster command to get nodes and slots, and we only can rename command name instead of subcommand, that is to say, users have a chance to change cluster topology, it is dangerous. Now, we use CLUSTERX command to set cluster topology, you can rename it if you don't want to expose this command to users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use
clustercommand to set cluster topology, as we know, we must allow users useclustercommand to get nodes and slots, and we only can rename command name instead of subcommand, that is to say, users have a chance to change cluster topology, it is dangerous.Now, we use
clusterxcommand to set cluster topology, you can rename it if you don't want to expose this command to users.