Skip to content

feat: Upgrade rocksdb to v7.7.3#1056

Merged
tisonkun merged 1 commit intoapache:unstablefrom
xiaobiaozhao:rocksdb-7
Nov 1, 2022
Merged

feat: Upgrade rocksdb to v7.7.3#1056
tisonkun merged 1 commit intoapache:unstablefrom
xiaobiaozhao:rocksdb-7

Conversation

@xiaobiaozhao
Copy link
Contributor

No description provided.

@tanruixiang
Copy link
Member

I suggest putting the test results and conclusions here or in the issue.

@xiaobiaozhao
Copy link
Contributor Author

I suggest putting the test results and conclusions here or in the issue.

Here is a simple test report

#1013 (comment)

@git-hulk git-hulk requested review from PragmaTwice, ShooterIT, caipengbo, tanruixiang, tisonkun and torwig and removed request for PragmaTwice November 1, 2022 04:11
@caipengbo caipengbo changed the title feat: Upgrade rocksdb to v7.7.5 feat: Upgrade rocksdb to v7.7.3 Nov 1, 2022
@git-hulk
Copy link
Member

git-hulk commented Nov 1, 2022

I think we can push forward to upgrading since the RocksDB community has confirmed the bad performance when compacting in 6.x and fixed in 7.5.3. Related issue: facebook/rocksdb#9423

Copy link
Contributor

@caipengbo caipengbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, LGTM!
Rocksdb 7.x has some new features that maybe we can add to kvrocks(like blob cache)

Copy link
Contributor

@torwig torwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tisonkun tisonkun merged commit 684bcc6 into apache:unstable Nov 1, 2022
@tisonkun
Copy link
Member

tisonkun commented Nov 1, 2022

Merged. Thank you!

git-hulk added a commit that referenced this pull request Nov 2, 2022
yanghonggang added a commit to yanghonggang/ceph that referenced this pull request Nov 21, 2022
- RocksDB community has confirmed the bad performance when compacting in 6.x and fixed in 7.5.3
  * facebook/rocksdb#9423
  * apache/kvrocks#1056
- new features(e.g., wal compression)

Signed-off-by: Yang Honggang <yanghonggang_yewu@cmss.chinamobile.com>
yanghonggang added a commit to yanghonggang/ceph that referenced this pull request Nov 21, 2022
- RocksDB community has confirmed the bad performance when compacting in 6.x and fixed in 7.5.3
  * facebook/rocksdb#9423
  * apache/kvrocks#1056
- new features(e.g., wal compression)

Signed-off-by: Yang Honggang <yanghonggang_yewu@cmss.chinamobile.com>
yanghonggang added a commit to yanghonggang/ceph that referenced this pull request Dec 27, 2022
- RocksDB community has confirmed the bad performance when compacting in 6.x and fixed in 7.5.3
  * facebook/rocksdb#9423
  * apache/kvrocks#1056
- new features(e.g., wal compression)

Signed-off-by: Yang Honggang <yanghonggang_yewu@cmss.chinamobile.com>
yanghonggang added a commit to yanghonggang/ceph that referenced this pull request Feb 13, 2023
- RocksDB community has confirmed the bad performance when compacting in 6.x and fixed in 7.5.3
  * facebook/rocksdb#9423
  * apache/kvrocks#1056
- new features(e.g., wal compression)

Signed-off-by: Yang Honggang <yanghonggang_yewu@cmss.chinamobile.com>
dparmar18 pushed a commit to dparmar18/ceph that referenced this pull request Mar 1, 2023
- RocksDB community has confirmed the bad performance when compacting in 6.x and fixed in 7.5.3
  * facebook/rocksdb#9423
  * apache/kvrocks#1056
- new features(e.g., wal compression)

Signed-off-by: Yang Honggang <yanghonggang_yewu@cmss.chinamobile.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants