KAFKA-10852: AlterIsr should not be throttled#9747
Merged
Conversation
This ensures it won't get throttled.
ijuma
commented
Dec 14, 2020
| List<ApiKeys> authenticationKeys = Arrays.asList(ApiKeys.SASL_HANDSHAKE, ApiKeys.SASL_AUTHENTICATE); | ||
| Set<ApiKeys> authenticationKeys = EnumSet.of(ApiKeys.SASL_HANDSHAKE, ApiKeys.SASL_AUTHENTICATE); | ||
| // Newer protocol apis include throttle time ms even for cluster actions | ||
| Set<ApiKeys> clusterActionsWithThrottleTimeMs = EnumSet.of(ApiKeys.ALTER_ISR); |
Member
Author
There was a problem hiding this comment.
We have to decide whether we want to do this or remove the throttle time ms from AlterIsr before 2.7.0.
Member
Author
There was a problem hiding this comment.
We decided this is not a blocker.
mumrah
approved these changes
Dec 14, 2020
Member
Author
|
@mumrah A couple of the test failures indicated that we had to change some code in KafkaApis too. Updated. |
Member
|
@ijuma, thanks! So, we'll keep the throttle field in the RPC, but we won't actually set the throttle. Seems reasonable 👍 |
Member
Author
|
Unrelated flaky test failures:
|
ijuma
added a commit
that referenced
this pull request
Dec 15, 2020
Set it as a cluster action and update the handler in KafkaApis. We keep the `throttleTimeMs` field since we intend to enable throttling in the future (especially relevant when we switch to the built-in quorum mode). Reviewers: David Arthur <mumrah@gmail.com>
Member
Author
|
Merged to trunk and 2.7 branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set it as a cluster action and update the handler in KafkaApis. We keep the throttleTimeMs field
since we intend to enable throttling in the future (especially relevant when we switch to the
built-in quorum mode).
Committer Checklist (excluded from commit message)