MINOR: fix log package AbstractIndex.scala file comment typo#9745
Merged
Conversation
chia7712
approved these changes
Dec 14, 2020
chia7712
left a comment
Member
There was a problem hiding this comment.
@panguncle Thanks for your patch. LGTM
ijuma
reviewed
Dec 14, 2020
| When doing warm-section lookup, following 3 entries are always touched: indexEntry(end), indexEntry(end-N), | ||
| and indexEntry((end*2 -N)/2). If page size >= 4096, all the warm-section pages (3 or fewer) are touched, when we | ||
| touch those 3 entries. As of 2018, 4096 is the smallest page size for all the processors (x86-32, x86-64, MIPS, | ||
| touch those 3 entries. As of 2048, 4096 is the smallest page size for all the processors (x86-32, x86-64, MIPS, |
Member
There was a problem hiding this comment.
This change doesn't make sense. 2018 was meant to be the year.
Member
There was a problem hiding this comment.
will revert it. sorry for rough merge :(
chia7712
added a commit
to chia7712/kafka
that referenced
this pull request
Dec 15, 2020
This reverts commit 8577cea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MINOR: fix log package
AbstractIndex.scalafile comment typo