KAFKA-9780: Deprecate commit records without record metadata#8379
Merged
Conversation
rhauch
requested changes
Apr 1, 2020
rhauch
left a comment
Contributor
There was a problem hiding this comment.
Thanks, @mmolimar. I think this PR looks good, and could potentially be merged as-is.
However, this is part of the public Connect API, so we'll need a KIP for any changes, including deprecations. I've commented as such on KAFKA-9780. I'm going to mark this as "Request Changes" (even though no changes are required to the commit) just to make sure we don't merge this before a KIP is approved.
Contributor
|
ok to test |
rhauch
approved these changes
May 6, 2020
Contributor
|
Still waiting for final approval of https://cwiki.apache.org/confluence/display/KAFKA/KIP-586%3A+Deprecate+commit+records+without+record+metadata |
Contributor
|
Green builds on JDK 11 and 8, and unrelated failure on JDK 14. |
Kvicii
pushed a commit
to Kvicii/kafka
that referenced
this pull request
May 22, 2020
* 'trunk' of github.com:apache/kafka: KAFKA-9980: Fix bug where alterClientQuotas could not set default client quotas (apache#8658) KAFKA-9780: Deprecate commit records without record metadata (apache#8379) MINOR: Deploy VerifiableClient in constructor to avoid test timeouts (apache#8651) MINOR: Added unit tests for ConnectionQuotas (apache#8650) MINOR: Correct MirrorMaker2 integration test configs for Connect internal topics (apache#8653) KAFKA-9855 - return cached Structs for Schemas with no fields (apache#8472) KAFKA-9950: Construct new ConfigDef for MirrorTaskConfig before defining new properties (apache#8608) KAFKA-8869: Remove task configs for deleted connectors from config snapshot (apache#8444) KAFKA-9409: Supplement immutability of ClusterConfigState class in Connect (apache#7942)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since KIP-382 (MirrorMaker 2.0) a new method
commitRecordwas included inSourceTaskclass to be called by the worker adding a new parameter with the record metadata. The oldcommitRecordmethod is called from the new one and it's preserved just for backwards compatibility.The idea is to deprecate this method so that we could remove it in a future release.
KIP-586.
Committer Checklist (excluded from commit message)