KAFKA-9267: ZkSecurityMigrator should not create /controller node#7778
Closed
NanerLee wants to merge 2 commits into
Closed
KAFKA-9267: ZkSecurityMigrator should not create /controller node#7778NanerLee wants to merge 2 commits into
NanerLee wants to merge 2 commits into
Conversation
omkreddy
reviewed
Dec 4, 2019
Contributor
There was a problem hiding this comment.
Can we use simple if.. else block for this?
84aaff9 to
3f9ca08
Compare
Contributor
Author
|
@omkreddy Please review this patch again. Thanks. |
omkreddy
approved these changes
Dec 5, 2019
| zkClient.makeSurePersistentPathExists(path) | ||
| setAclsRecursively(path) | ||
| if (path == ControllerZNode.path && !zkClient.pathExists(path)) { | ||
| debug("Ignoring to set ACL for %s, because it doesn't exist".format(path)) |
Contributor
There was a problem hiding this comment.
nit: we can use string-interpolation
Suggested change
| debug("Ignoring to set ACL for %s, because it doesn't exist".format(path)) | |
| debug(s"Ignoring to set ACL for $path, because it doesn't exist") |
Contributor
Author
There was a problem hiding this comment.
You're right, but I just want to keep the code style.
Because other codes use the format() function.
Thanks.
Contributor
Author
|
retest this please. |
Contributor
Author
|
@omkreddy Testes have been passed, do I have to do anything else? |
gitlw
pushed a commit
to linkedin/kafka
that referenced
this pull request
Jun 16, 2021
…create /controller node [KAFKA-9267](https://issues.apache.org/jira/browse/KAFKA-9267) ZkSecurityMigrator might create a PERSISTENT /controller node with null data, it will lead to controller can't elect. *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.* Author: NanerLee <nanerlee@qq.com> Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com> Closes apache#7778 from NanerLee/fix-ZkSecurityMigrator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KAFKA-9267
ZkSecurityMigrator might create a PERSISTENT /controller node with null data, it will lead to controller can't elect.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)