KAFKA-9244: Update FK reference should unsubscribe old FK#7758
Conversation
bellemare
left a comment
There was a problem hiding this comment.
Wow. Thanks. Excellent catch!
|
@mjsax Is this going to go out with 2.4? |
|
Is this a regression? |
|
Looks right to me. Thanks for the fix and the test, @mjsax! There was some kind of gradle exception in the build. Retest this, please. |
|
@ijuma Foreign key join is a newly added feature in 2.4.0 -- hence, it's technically not a regression. However, we would ship a broker feature if we don't include this fix in 2.4.0 because there is no workaround. Thoughts? While investigating this issue, I also discovered another bug in FK join operator: https://issues.apache.org/jira/browse/KAFKA-9248 -- However, for this other bug a workaround exists and thus it's not critical to get a fix into 2.4.0. |
|
Can we get this merged today so that @omkreddy can release a new RC tomorrow? |
Reviewers: Adam Bellemare <adam.bellemare@wishabi.com>, John Roesler <john@confluent.io>
|
Merged to |
Call for review @vvcephei @bellemare