Skip to content

KAFKA-8454: Add Java AdminClient Interface (KIP-476)#7087

Merged
hachikuji merged 7 commits into
apache:trunkfrom
big-andy-coates:KIP-476_Add_Java_AdminClient_Interface
Jul 22, 2019
Merged

KAFKA-8454: Add Java AdminClient Interface (KIP-476)#7087
hachikuji merged 7 commits into
apache:trunkfrom
big-andy-coates:KIP-476_Add_Java_AdminClient_Interface

Conversation

@big-andy-coates

@big-andy-coates big-andy-coates commented Jul 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

KIP-476

Adds a Admin interface.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@big-andy-coates

big-andy-coates commented Jul 14, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

ping @cmccabe, @mjsax, @rajinisivaram for a review please

I've added the Admin interface, removed most of the AdminClient impl, and updates references in the docs to AdminClient where I think it's appropriate.

ijuma
ijuma reviewed Jul 14, 2019
View reviewed changes
Comment thread clients/src/main/java/org/apache/kafka/clients/admin/AdminClient.java Outdated
hachikuji
hachikuji reviewed Jul 17, 2019
View reviewed changes

@hachikuji hachikuji left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple minor comments, but looks good overall.

Comment thread clients/src/main/java/org/apache/kafka/clients/admin/AdminClient.java
* This client was introduced in 0.11.0.0 and the API is still evolving. We will try to evolve the API in a compatible
* manner, but we reserve the right to make breaking changes in minor releases, if necessary. We will update the
* {@code InterfaceStability} annotation and this notice once the API is considered stable.
* This class may be removed in a later release, but has not be marked as deprecated to avoid unnecessary noise.

@hachikuji hachikuji Jul 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was probably discussed in the KIP, but obviously the downside is that users won't get any warning or hint that they should transition. But I guess we don't get a substantial benefit from removing AdminClient, so maybe we'll just never do it.

@big-andy-coates big-andy-coates Jul 17, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but this was covered / discussed in detail on the voting thread and this was the outcome.

Comment thread checkstyle/suppressions.xml Outdated
@hachikuji

hachikuji commented Jul 17, 2019

Copy link
Copy Markdown
Contributor

retest this please

hachikuji
hachikuji approved these changes Jul 18, 2019
View reviewed changes

@hachikuji hachikuji left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hachikuji hachikuji changed the title KIP-476: Add Java AdminClient Interface KAFKA-8454: Add Java AdminClient Interface (KIP-476) Jul 18, 2019
@hachikuji

hachikuji commented Jul 18, 2019

Copy link
Copy Markdown
Contributor

retest this please

3 similar comments
@big-andy-coates

big-andy-coates commented Jul 18, 2019

Copy link
Copy Markdown
Contributor Author

retest this please

@big-andy-coates

big-andy-coates commented Jul 18, 2019

Copy link
Copy Markdown
Contributor Author

retest this please

@big-andy-coates

big-andy-coates commented Jul 19, 2019

Copy link
Copy Markdown
Contributor Author

retest this please

@hachikuji hachikuji merged commit 2a133ba into apache:trunk Jul 22, 2019
@big-andy-coates big-andy-coates deleted the KIP-476_Add_Java_AdminClient_Interface branch July 23, 2019 08:02
@dongjinleekr dongjinleekr mentioned this pull request Aug 15, 2019
Closed
3 tasks
omkreddy pushed a commit that referenced this pull request Nov 29, 2019
@dongjinleekr @omkreddy
MINOR: Improve Admin interface Documentation
446be12 
This PR is a follow-up of #7087, fixing typos, styles, etc.

cc/ big-andy-coates ijuma

Author: Lee Dongjin <dongjin@apache.org>

Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>

Closes #7217 from dongjinleekr/feature/trivial-admin-javadoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ijuma ijuma ijuma left review comments

@hachikuji hachikuji hachikuji approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@big-andy-coates @hachikuji @ijuma