KAFKA-7904: Add AtMinIsr partition metric and TopicCommand option (KIP-427)#6421
Closed
KevinLiLu wants to merge 4 commits into
Closed
KAFKA-7904: Add AtMinIsr partition metric and TopicCommand option (KIP-427)#6421KevinLiLu wants to merge 4 commits into
KevinLiLu wants to merge 4 commits into
Conversation
Contributor
Author
|
Hi @harshach @vahidhashemian @lindong28 , can I get a review for this? |
Contributor
Author
|
Bumping this as it has been a couple weeks. Can I get a review? @harshach @vahidhashemian @lindong28 @gwenshap |
gwenshap
requested changes
Apr 5, 2019
gwenshap
left a comment
Contributor
There was a problem hiding this comment.
Looks good. One small request.
| allTopicLevelOpts -- Set(describeOpt) + reportUnderMinIsrPartitionsOpt + reportUnavailablePartitionsOpt + reportAtMinIsrPartitionsOpt + topicsWithOverridesOpt) | ||
| CommandLineUtils.checkInvalidArgs(parser, options, reportUnderMinIsrPartitionsOpt, | ||
| allTopicLevelOpts -- Set(describeOpt) + reportUnderReplicatedPartitionsOpt + reportUnavailablePartitionsOpt + topicsWithOverridesOpt + zkConnectOpt) | ||
| allTopicLevelOpts -- Set(describeOpt) + reportUnderReplicatedPartitionsOpt + reportUnavailablePartitionsOpt + reportAtMinIsrPartitionsOpt + topicsWithOverridesOpt + zkConnectOpt) |
Contributor
There was a problem hiding this comment.
Nit:
We repeatedly add reportUnderReplicatedPartitionsOpt, reportUnavailablePartitionsOpt, reportAtMinIsrPartitionsOpt and reportUnderMinIsrPartitionsOpt to the set of disallowed options, and it is messy to read (and a . Maybe create a new set like allReplicationReportOpts and use this everywhere?
Contributor
Author
There was a problem hiding this comment.
Great idea. Thanks!
Contributor
Author
|
Hi @gwenshap , thanks for the review. I have refactored the options code to use an |
Contributor
|
Thank you. Looks good and tests pass. Merging. |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…P-427) - Add `AtMinIsrPartitionCount` metric to `ReplicaManager` - Add `AtMinIsr` metric to `Partition` - Add `--at-min-isr-partitions` describe `TopicCommand` option https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=103089398 Author: Kevin Lu <lu.kevin@berkeley.edu> Author: lu.kevin@berkeley.edu <kelu@paypal.com> Reviewers: Gwen Shapira Closes apache#6421 from KevinLiLu/KAFKA-7904
xiowu0
pushed a commit
to xiowu0/kafka
that referenced
this pull request
Jul 15, 2019
…and TopicCommand option (KIP-427) TICKET = KAFKA-7904 LI_DESCRIPTION = This patch includes broker metrics for AtMinIsr and modified unit tests. However, it doesn't include topiccommand related change from the original cherry-picked commit because of extra dependency. EXIT_CRITERIA = HASH [31d191f] ORIGINAL_DESCRIPTION = - Add `AtMinIsrPartitionCount` metric to `ReplicaManager` - Add `AtMinIsr` metric to `Partition` - Add `--at-min-isr-partitions` describe `TopicCommand` option https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=103089398 Author: Kevin Lu <lu.kevin@berkeley.edu> Author: lu.kevin@berkeley.edu <kelu@paypal.com> Reviewers: Gwen Shapira Closes apache#6421 from KevinLiLu/KAFKA-7904 (cherry picked from commit 31d191f)
xiowu0
added a commit
to linkedin/kafka
that referenced
this pull request
Jul 16, 2019
…and TopicCommand option (KIP-427) (#30) TICKET = KAFKA-7904 LI_DESCRIPTION = This patch includes broker metrics for AtMinIsr and modified unit tests. However, it doesn't include topiccommand related change from the original cherry-picked commit because of extra dependency. EXIT_CRITERIA = HASH [31d191f] ORIGINAL_DESCRIPTION = - Add `AtMinIsrPartitionCount` metric to `ReplicaManager` - Add `AtMinIsr` metric to `Partition` - Add `--at-min-isr-partitions` describe `TopicCommand` option https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=103089398 Author: Kevin Lu <lu.kevin@berkeley.edu> Author: lu.kevin@berkeley.edu <kelu@paypal.com> Reviewers: Gwen Shapira Closes apache#6421 from KevinLiLu/KAFKA-7904 (cherry picked from commit 31d191f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AtMinIsrPartitionCountmetric toReplicaManagerAtMinIsrmetric toPartition--at-min-isr-partitionsdescribeTopicCommandoptionhttps://cwiki.apache.org/confluence/pages/viewpage.action?pageId=103089398
Committer Checklist (excluded from commit message)