MINOR: Fix JMX serialization by reverting #5011#5114
Conversation
|
@apurvam, this looks related to the issue you were seeing in KSQL recently. |
|
@rayokota Note the findbugs error. |
|
Sorry for problem caused by that patch. Thanks much for catching this! |
…y calculating JMX attributes" This reverts commit c9ec292.
911732c to
7a2f923
Compare
|
@lindong28 , @radai-rosenblatt , I've reverted #5011 for now as the simple fix that I had was probably not going to give you the performance benefit that you want. Originally I thought that I could simply move the anonymous inner class to be a static class, but the class still needs to be serializable so right now referring to the If you still want to try to achieve lazy calculation of the |
|
JMX metrics read via RMI rely on Serialization. Simply using JConsole should trigger this path. |
|
@rayokota Sure. Thanks for catching and fixing this issue! Radai will update the patch and add the serialization logic and the test. |
|
retest this please |
|
I merged this to trunk. Next step is for @radai-rosenblatt to resubmit as @lindong28 said. |
…ributes (apache#5114) This reverts commit c9ec292 (apache#5011). That commit introduces an anonymous inner class which retains a reference to the non-serializable outer class `KafkaMbean` breaking Serialization. This means that reading JMX metrics via JConsole or JmxTool no longer works since RMI relies on Java Serialization. Reviewers: Jason Gustafson <jason@confluent.io>, Dong Lin <lindong28@gmail.com>, Ismael Juma <ismael@juma.me.uk>
A recent change returns an anonymous inner class which retains
a reference to the outer class, KafkaMbean, which is not serializable.
This commit reverts #5011 as a proper fix needs to probably do serialization lazily as well by overriding
readObjectandwriteObject.Committer Checklist (excluded from commit message)