KAFKA-6973: TopicCommand should verify topic-level config#5106
Merged
Conversation
…mestamp.type`. Specifying an invalid config other than `CreateTime` or `LogAppendTime` will cause broker restarting to fail.
Contributor
Author
|
@ijuma Please review this minor patch. Thanks. |
Contributor
|
LGTM. |
Contributor
Author
|
@omkreddy thanks for responding, so can it be merged to the trunk? |
ijuma
reviewed
Jun 1, 2018
ijuma
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR, just a minor comment.
| TestUtils.createBrokersInZk(zkClient, brokers) | ||
|
|
||
| val topic = "test" | ||
| val numPartitions = 1 |
Member
There was a problem hiding this comment.
We don't need these variables since they're just used once.
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
Specifying an invalid config (i.e. something other than `CreateTime` or `LogAppendTime`) via `TopicCommand` would previously cause the broker to fail on start-up. Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>, Ismael Juma <ismael@juma.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KAFKA-6973: https://issues.apache.org/jira/browse/KAFKA-6973
Specifying an invalid config other than
CreateTimeorLogAppendTimewill cause broker restarting to fail.More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)