MINOR: fix streams test-utils dependencies#4821
Merged
Merged
Conversation
Contributor
Author
|
@mjsax @guozhangwang @bbejeck @ewencp Hey all, do you mind giving this a review? I also sent a message to the mailing list. |
Contributor
|
I like this PR since it does not users to declare two dependencies, streams and streams-utils, but just the streams-utils. |
Contributor
Author
|
Thanks folks. If there's no more feedback, should we merge this? |
ying-zheng
pushed a commit
to ying-zheng/kafka
that referenced
this pull request
Jul 6, 2018
Reviewers: Bill Bejeck <bill@confluent.io>, Matthias J. Sax <matthias@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to @ewencp 's PR #4816 (a fix of my #4760).
Break the cycle on the other side so that
:streams:test-utilscan declare a regular dependency on:streams.To test that we don't re-introduce the bug that #4816 fixed, do the following:
That latter command should return only the following (instead of 580 class files):
Committer Checklist (excluded from commit message)