Skip to content

KAFKA-2586; Enable SSL for inter-broker communication when SSL is enabled in tests#252

Closed
ijuma wants to merge 1 commit into
apache:trunkfrom
ijuma:kafka-2586-enable-inter-broker-ssl-in-tests
Closed

KAFKA-2586; Enable SSL for inter-broker communication when SSL is enabled in tests#252
ijuma wants to merge 1 commit into
apache:trunkfrom
ijuma:kafka-2586-enable-inter-broker-ssl-in-tests

Conversation

@ijuma

@ijuma ijuma commented Sep 28, 2015

Copy link
Copy Markdown
Member

No description provided.

@ijuma ijuma changed the title Enable SSL for inter-broker communication when SSL is enabled in tests KAFKA-2586; Enable SSL for inter-broker communication when SSL is enabled in tests Sep 28, 2015
@asfbot

asfbot commented Sep 28, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #575 FAILURE
Looks like there's a problem with this pull request

@ijuma

ijuma commented Sep 28, 2015

Copy link
Copy Markdown
Member Author

Tests passed locally. Failed test in Jenkins is SyncProducerTest, which doesn't use SSL.

@junrao

junrao commented Sep 28, 2015

Copy link
Copy Markdown
Contributor

Thanks for the patch. LGTM.

@asfgit asfgit closed this in f540f4a Sep 28, 2015
@ijuma ijuma deleted the kafka-2586-enable-inter-broker-ssl-in-tests branch March 1, 2016 22:50
efeg added a commit to efeg/kafka that referenced this pull request Jan 29, 2020
blcksrx pushed a commit to blcksrx/kafka that referenced this pull request Feb 15, 2020
Removed legacy module to reduce maintenance overhead.

Moved `SupportedKafka` to core module, deprecated it
and simplified it. It now just forwards to `Kafka`.

Fixed some compiler warnings in support-metrics-common.

Reviewers: Manikumar Reddy <manikumar.reddy@gmail.com>
davide-armand pushed a commit to aiven/kafka that referenced this pull request Dec 1, 2025
This allows faster file commits (no constant scans of the `batches` table) and the `batches` will take smaller space, because it won't store all the history of sequences. The benchmark (in the end of the commit message) shows 10x speedup.

This will also fix a potential (but very unlikely) problem with wraparound sequences where we may end up having multiple batches with the same base and last sequences, which would result in incorrect detection of duplicates.

This commit also fixes a bug with incorrect returned assigned offset for duplicate batches.
jeqo pushed a commit to aiven/kafka that referenced this pull request Jan 16, 2026
This allows faster file commits (no constant scans of the `batches` table) and the `batches` will take smaller space, because it won't store all the history of sequences. The benchmark (in the end of the commit message) shows 10x speedup.

This will also fix a potential (but very unlikely) problem with wraparound sequences where we may end up having multiple batches with the same base and last sequences, which would result in incorrect detection of duplicates.

This commit also fixes a bug with incorrect returned assigned offset for duplicate batches.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants