KAFKA-2554: change 0.8.3 to 0.9.0 in ApiVersion and other files#237
KAFKA-2554: change 0.8.3 to 0.9.0 in ApiVersion and other files#237omkreddy wants to merge 1 commit into
Conversation
|
kafka-trunk-git-pr #524 FAILURE |
There was a problem hiding this comment.
Is it true that the version can have 4 segments? In ApiVersion.versionNameMap, it always has 3 segments.
There was a problem hiding this comment.
Yes, We can have 4 segments. But we will take first 3 segments for processing/version checks.
There was a problem hiding this comment.
So, isn't it a bit misleading to use 4 segments? It sounds to me like we would never want to change the protocol when bumping a the fourth segment.
There was a problem hiding this comment.
We never want to change protocol on segment 4, but we want users to be able to type 0.9.0.1 without getting errors, just to make it more intuitive.
There was a problem hiding this comment.
I find it less intuitive, personally. If there is no consensus, then yeah, this doesn't have to be handled in this PR.
|
Changes LGTM and I'll merge after Jenkins updates with test results. @ijuma concerns on the number of segments we support can be addressed in a separate jira, since this once just deals with the new version number. |
TICKET = LIKAFKA-9737 LI_DESCRIPTION = Broker-side changes for pass-through solution. This is the porting for commit 0d9c527 EXIT_CRITERIA = MANUAL ["If we no longer need pass-through support in Kafka. Only known user is KMM for venice; BrooklinMM has not enabled this everywhere."] Co-authored-by: Lucas Wang <luwang@linkedin.com>
TICKET = LIKAFKA-9737 LI_DESCRIPTION = Broker-side changes for pass-through solution. This is the porting for commit 0d9c527 EXIT_CRITERIA = MANUAL ["If we no longer need pass-through support in Kafka. Only known user is KMM for venice; BrooklinMM has not enabled this everywhere."] Co-authored-by: Lucas Wang <luwang@linkedin.com>
TICKET = LIKAFKA-9737 LI_DESCRIPTION = Broker-side changes for pass-through solution. This is the porting for commit 0d9c527 EXIT_CRITERIA = MANUAL ["If we no longer need pass-through support in Kafka. Only known user is KMM for venice; BrooklinMM has not enabled this everywhere."] Co-authored-by: Lucas Wang <luwang@linkedin.com>
TICKET = LIKAFKA-9737 LI_DESCRIPTION = Broker-side changes for pass-through solution. This is the porting for commit 0d9c527 EXIT_CRITERIA = MANUAL ["If we no longer need pass-through support in Kafka. Only known user is KMM for venice; BrooklinMM has not enabled this everywhere."] Co-authored-by: Lucas Wang <luwang@linkedin.com>
Updated the version from 0.8.3 to 0.9.0. in ApiVersion. Also updated in gradle.propeties.