KAFKA-2576; ConsumerPerformance hangs when SSL enabled for Multi-Partition Topic#236
KAFKA-2576; ConsumerPerformance hangs when SSL enabled for Multi-Partition Topic#236ijuma wants to merge 1 commit into
Conversation
We now write to the channel with an empty buffer when there are pending bytes remaining and all data has been sent.
|
kafka-trunk-git-pr #501 FAILURE |
|
+1 |
There was a problem hiding this comment.
NP: could this just be
if (buffer.hasRemaining)
written += channel.write(buffer)
else{...
There was a problem hiding this comment.
No, because the buffer is mutated.
|
Tested this on an EC2 cluster and it looks good 👍 |
|
Thanks for testing Ben. |
There was a problem hiding this comment.
It seems that we can just reference ErrorMapping.EmptyByteBuffer?
There was a problem hiding this comment.
We could do that. A few concerns: it's a bit strange that the empty buffer lives in ErrorMapping, it doesn't seem to be used anywhere at the moment and ByteBuffer has a number of mutation methods (although most of them don't do anything for an empty buffer). If you think it's worth having a shared empty buffer, maybe we could put it in ApiUtils as a private[api] value?
There was a problem hiding this comment.
Ok. Then what you had is fine. Did the unit tests pass?
There was a problem hiding this comment.
Yes, they passed when I ran them locally.
…mentation (apache#236) TICKET = LIKAFKA-21968 LI_DESCRIPTION = The observer interface lets us provide an implementation that provides the usage accounting data unit for the C2S V3 service. EXIT_CRITERIA = MANUAL [""] Co-authored-by: Lincong Li <lcli@linkedin.com>
…mentation (apache#236) TICKET = LIKAFKA-21968 LI_DESCRIPTION = The observer interface lets us provide an implementation that provides the usage accounting data unit for the C2S V3 service. EXIT_CRITERIA = MANUAL [""] Co-authored-by: Lincong Li <lcli@linkedin.com>
…mentation (apache#236) TICKET = LIKAFKA-21968 LI_DESCRIPTION = The observer interface lets us provide an implementation that provides the usage accounting data unit for the C2S V3 service. EXIT_CRITERIA = MANUAL [""] Co-authored-by: Lincong Li <lcli@linkedin.com>
…mentation (apache#236) TICKET = LIKAFKA-21968 LI_DESCRIPTION = The observer interface lets us provide an implementation that provides the usage accounting data unit for the C2S V3 service. EXIT_CRITERIA = MANUAL [""] Co-authored-by: Lincong Li <lcli@linkedin.com>
* KAFKA-855 could not get TopicInfo, err 13 * correctly added hadoop-common to tests * moved new dependency configuration to testCompile section
The main goal is to keep the Inkless topic creation as close as possible to the classic topic creation.
The main goal is to keep the Inkless topic creation as close as possible to the classic topic creation.
We now write to the channel with an empty buffer when
there are pending bytes remaining and all data has been
sent.