Skip to content

KAFKA-2558: ServerShutdownTest is failing intermittently#224

Closed
fpj wants to merge 3 commits into
apache:trunkfrom
fpj:KAFKA-2558
Closed

KAFKA-2558: ServerShutdownTest is failing intermittently#224
fpj wants to merge 3 commits into
apache:trunkfrom
fpj:KAFKA-2558

Conversation

@fpj

@fpj fpj commented Sep 20, 2015

Copy link
Copy Markdown
Contributor

See jira for a description.

@asfbot

asfbot commented Sep 20, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #452 FAILURE
Looks like there's a problem with this pull request

@onurkaraman

onurkaraman commented Sep 20, 2015

Copy link
Copy Markdown
Contributor

LGTM.

I ran into this issue yesterday:
https://issues.apache.org/jira/browse/KAFKA-2438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876573#comment-14876573

@fpj

fpj commented Sep 20, 2015

Copy link
Copy Markdown
Contributor Author

Thanks for checking @onurkaraman

ijuma
ijuma reviewed Sep 20, 2015
View reviewed changes
Comment thread core/src/main/scala/kafka/controller/ControllerChannelManager.scala Outdated

@ijuma ijuma Sep 20, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing a parameter called testName to a non test class is not ideal. We could either override the thread creation in the test or pass a more generic parameter (maybe requestThreadNamePrefix). What do you think?

@fpj fpj Sep 20, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with making the name more generic (e.g., threadNamePrefix).

@guozhangwang guozhangwang Sep 21, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think threadNamePrefix is fine.

@guozhangwang

guozhangwang commented Sep 21, 2015

Copy link
Copy Markdown
Contributor

Could you fix TestUtils.verifyNonDaemonThreadsStatus also?

@asfbot

asfbot commented Sep 21, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #470 FAILURE
Looks like there's a problem with this pull request

@asfbot

asfbot commented Sep 21, 2015

Copy link
Copy Markdown

kafka-trunk-git-pr #474 SUCCESS
This pull request looks good

@asfgit asfgit closed this in 4833d8a Sep 22, 2015
@guozhangwang

guozhangwang commented Sep 22, 2015

Copy link
Copy Markdown
Contributor

LGTM.

jsancio pushed a commit to jsancio/kafka that referenced this pull request Aug 6, 2019
@cmccabe
CONFLUENT: Delete multi_tenant_test.py (apache#224)
853fcb5 
multi_tenant_test.py is mostly testing OAuth, not multi-tenancy.  Its
functionality is duplicated by the CCloud tests.
udaynpusa pushed a commit to mapr/kafka that referenced this pull request Jan 30, 2024
@achernatsky
KAFKA-804 Netty CVE for kafka components (apache#224)
17e8dbe
davide-armand pushed a commit to aiven/kafka that referenced this pull request Dec 1, 2025
@jeqo
fix(inkless:consume): return hwm when auto reset to latest [INK-20] (a…
f635c1b 
…pache#224)
jeqo added a commit to aiven/kafka that referenced this pull request Jan 16, 2026
@jeqo
fix(inkless:consume): return hwm when auto reset to latest [INK-20] (a…
d44e9c0 
…pache#224)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fpj @asfbot @onurkaraman @guozhangwang @ijuma