MINOR: Making sure log appender is closed in ShareConsumerImplTest.java::testFailConstructor#20514
Merged
chia7712 merged 2 commits intoSep 9, 2025
Merged
Conversation
Member
|
Thanks @gensericghiro ! Could you add the MINOR prefix to the title? |
chia7712
reviewed
Sep 9, 2025
chia7712
left a comment
Member
There was a problem hiding this comment.
@gensericghiro thanks for this patch. LGTM
chia7712
approved these changes
Sep 9, 2025
eduwercamacaro
pushed a commit
to littlehorse-enterprises/kafka
that referenced
this pull request
Nov 12, 2025
…va::testFailConstructor (apache#20514) Similarly to what was done for AsyncKafkaConsumerTest::testFailConstructor, [here](apache#20491) Reviewers: Lianet Magrans <lmagrans@confluent.io>, Chia-Ping Tsai <chia7712@gmail.com>
shashankhs11
pushed a commit
to shashankhs11/kafka
that referenced
this pull request
Dec 15, 2025
…va::testFailConstructor (apache#20514) Similarly to what was done for AsyncKafkaConsumerTest::testFailConstructor, [here](apache#20491) Reviewers: Lianet Magrans <lmagrans@confluent.io>, Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Similarly to what was done for
AsyncKafkaConsumerTest::testFailConstructor,
here
Reviewers: Lianet Magrans lmagrans@confluent.io, Chia-Ping Tsai
chia7712@gmail.com