KAFKA-18050: Upgrade the checkstyle version to 10.20.2#17999
Conversation
|
@m1a2st please rebase code |
|
@m1a2st you may also use latest Checkstyle patch version (10.20.2) |
# Conflicts: # gradle/dependencies.gradle
# Conflicts: # clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
|
@dejan2609 I found there is an error when I use the version of 10.20.2, PTAL, Thanks for your helping https://github.com/apache/kafka/actions/runs/12122917186/job/33797238123?pr=17999 |
|
It will be awesome to create separate PR after merge of this PR to update to latest checkstyle and share report content to let us review how it was possible to generate bad xml |
I agree with that, @romani. Anyhow: I tested (on my computer) this branch with Checkstyle 10.20.2 and it compiles just fine. Maybe Github Actions build went berserk 😃 ? We will check eventually. |
|
Let's merge this PR first. |
I run the 10.20.2 on #18010, and it works well.
I have updated this PR to use version 10.20.2 again. Let's see what happens this time. |
| @@ -61,7 +61,7 @@ versions += [ | |||
| // when updating checkstyle, check whether the exclusion of | |||
There was a problem hiding this comment.
Could you please remove those comments? they are out-of-date after you upgrade the checkstyle version
|
The failed test is traced by https://issues.apache.org/jira/browse/KAFKA-18036 |
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Jira: https://issues.apache.org/jira/browse/KAFKA-18050
As we don't support the Java version8, we can avoid the CVE-2023-2976 and CVE-2020-8908m thus we should upgrade the checkstyle version, and some file are missed in old version checkstyle, thus we should upgrade the checkstyle version.
Committer Checklist (excluded from commit message)