Skip to content

MINOR Mark PlaintextAdminIntegrationTest#testShareGroups as flaky#17649

Merged
mumrah merged 1 commit into
apache:trunkfrom
mumrah:oct-31-flaky-tests
Oct 31, 2024
Merged

MINOR Mark PlaintextAdminIntegrationTest#testShareGroups as flaky#17649
mumrah merged 1 commit into
apache:trunkfrom
mumrah:oct-31-flaky-tests

Conversation

@mumrah

@mumrah mumrah commented Oct 31, 2024

Copy link
Copy Markdown
Member

Looks like this regressed in #16842

@github-actions github-actions Bot added core Kafka Broker tests Test fixes (including flaky tests) small Small PRs labels Oct 31, 2024
@mumrah mumrah added the KIP-932 Queues for Kafka label Oct 31, 2024

@AndrewJSchofield AndrewJSchofield left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this has become flaky.

@rondagostino rondagostino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mumrah mumrah merged commit 7c536c9 into apache:trunk Oct 31, 2024
@mumrah mumrah deleted the oct-31-flaky-tests branch October 31, 2024 14:19
@chia7712

Copy link
Copy Markdown
Member

This test isn't flaky, as it consistently fails no matter how many retries we attempt, correct? If that's the case, we should disable it rather than quarantine it, since it still breaks our CI.

abhishekgiri23 pushed a commit to abhishekgiri23/kafka that referenced this pull request Nov 2, 2024
…7649)

Reviewers: Andrew Schofield <aschofield@confluent.io>, Ron Dagostino <rndgstn@gmail.com>
chiacyu pushed a commit to chiacyu/kafka that referenced this pull request Nov 30, 2024
…7649)

Reviewers: Andrew Schofield <aschofield@confluent.io>, Ron Dagostino <rndgstn@gmail.com>
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
…7649)

Reviewers: Andrew Schofield <aschofield@confluent.io>, Ron Dagostino <rndgstn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Kafka Broker KIP-932 Queues for Kafka small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants