MINOR Enable the GitHub build by default#17105
Conversation
|
We might want to wait on #17106 (and any follow-ups) to better utilize the build cache before turning this on for all PRs. |
|
@chia7712 WDYT, should we go ahead with this one? |
chia7712
left a comment
There was a problem hiding this comment.
should we go ahead with this one?
What you are about to do, I'm gonna to enjoy it, very, very much 😄
while leaving the github-actions-opt-in variable in place for future experiments.
Instead of dropping all usages of github-actions-opt-in, maybe we should change the default value of github-actions-opt-in to true.
If we do that, we could probably just remove the input parameter. As it stands, we don't have any use cases for it, so maybe we should do that? |
+1, we can always add it back in future experiments |
|
@chia7712 lmk if there's anything remaining on this one. Otherwise lets merge it |
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Per the discussion in the dev mailing list, we should enable the new GitHub Actions workflows for all PRs.
This patch does just that, while leaving the
github-actions-opt-invariable in place for future experiments.Also included is a script that committers can use for approving workflow runs en-masse. Based on my experience, opening several tabs and clicking "Approve and Run" is rather tedious. The script utilizes the
ghCLI which must be installed.