KAFKA-17482: Make share partition initialization async (KIP-932)#17097
Merged
Conversation
Contributor
Author
|
@AndrewJSchofield @adixitconfluent @omkreddy Build passed with unrelated tests failure. Can you please take a look. |
AndrewJSchofield
approved these changes
Sep 6, 2024
AndrewJSchofield
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. I note the comment about the future use of the purgatory to properly handle initialization which exceeds the duration of the desired wait time. That's important and coming in a later PR. Subject to that proviso, approved.
Contributor
Author
|
@AndrewJSchofield @omkreddy Build passed with unrelated test failures. |
omkreddy
approved these changes
Sep 9, 2024
omkreddy
left a comment
Contributor
There was a problem hiding this comment.
@apoorvmittal10 Thanks for the PR. LGTM
mingyen066
pushed a commit
to mingyen066/kafka
that referenced
this pull request
Sep 10, 2024
…che#17097) The PR introduces states for share partition which are used to make share partition initilzation async. Reviewers: Andrew Schofield <aschofield@confluent.io>, Manikumar Reddy <manikumar.reddy@gmail.com>
tedyu
pushed a commit
to tedyu/kafka
that referenced
this pull request
Jan 6, 2025
…che#17097) The PR introduces states for share partition which are used to make share partition initilzation async. Reviewers: Andrew Schofield <aschofield@confluent.io>, Manikumar Reddy <manikumar.reddy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR introduces states for share partition which are used to make share partition initilzation async.
Committer Checklist (excluded from commit message)