MINOR Handle test re-runs in junit.py#17034
Merged
Merged
Conversation
Member
Author
|
The "Details" link in the PR status check takes you to the failure in the workflow. I've added console logs so we can see the test failures right away. 
The markdown summary now includes separate tables for failed, flaky, and skipped tests. 
|
chia7712
reviewed
Aug 30, 2024
| report_md = f"Download [HTML report]({report_url})." | ||
| summary = f"{total_tests} tests run in {duration}, {total_failures} failed ❌, {total_skipped} skipped ⚠️, {total_errors} errors." | ||
| logger.debug(summary) | ||
| summary = f"{total_tests} tests run in {duration}, {total_failures} {FAILED}, {total_flaky} {FLAKY}, {total_skipped} {SKIPPED}, and {total_errors} errors." |
Member
There was a problem hiding this comment.
The tests shown by "Failed Tests" table exclude the "flaky". Does it confuse readers that the "number of failed" is NOT equal to the number of tests shown by "Failed Tests" table.
Member
Author
There was a problem hiding this comment.
Thanks, I noticed this too. Latest commit should fix this
Member
Author
|
Latest run shows the tables match the summary count. https://github.com/apache/kafka/actions/runs/10638037021?pr=17034 |
chia7712
approved these changes
Aug 31, 2024
mumrah
added a commit
to mumrah/kafka
that referenced
this pull request
Sep 1, 2024
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
bboyleonp666
pushed a commit
to bboyleonp666/kafka
that referenced
this pull request
Sep 4, 2024
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we are using the Develocity retry test feature, it is possible to see a test fail and also pass in the same suite. Add support to this for the junit report generation. Also move the skipped tests into a different table.