MINOR: Clean up of ConsumerCoordinator and PartitionAssignor.#1306
MINOR: Clean up of ConsumerCoordinator and PartitionAssignor.#1306Ishiihara wants to merge 2 commits into
Conversation
|
@hachikuji Not a big deal. Just some clean up. |
|
The clean-ups are fine, but neither of the two files changed are |
|
@ijuma It is Kafka Consumer internals. |
|
@granthenke I know that (obviously). :) I was suggesting that we can make the PR title (and hence commit message) clearer. Something like |
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
| import java.util.Collection; |
There was a problem hiding this comment.
Checkstyle doesn't like this import since it's only used in the javadoc. You might need to use the full name in the javadoc instead.
|
@ijuma @granthenke Thanks for the review and suggestion on making the tile more clear. |
|
@ijuma @granthenke @hachikuji Addressed the review comments. Would you mind to take another look? |
|
LGTM |
|
LGTM apart from a typo in the PR title, it's |
|
@ijuma Thanks for the catch and careful review! |
Author: Liquan Pei <liquanpei@gmail.com> Reviewers: Jason Gustafson <jason@confluent.io>, Ismael Juma <ismael@juma.me.uk> Closes apache#1306 from Ishiihara/minor-consumer-cleanup
…ing resource history. (apache#1306)
…ache#1306) (#21) Co-authored-by: Apoorv Mittal <apoorvmittal10@gmail.com>
No description provided.