KAFKA-14337: correctly remove topicsWithCollisionChars after topic deletion#12790
Merged
Conversation
showuon
commented
Oct 26, 2022
Member
Author
There was a problem hiding this comment.
The key for topicsWithCollisionChars should be normalized name, not original name.
Member
Author
|
@dengziming @cmccabe , please take a look. Thanks. |
dengziming
reviewed
Oct 27, 2022
dengziming
left a comment
Member
There was a problem hiding this comment.
Nice catch @showuon , can we also add a test in ReplicationControlManagerTest?
| TestUtils.verifyTopicDeletion(zkClientOrNull, topicWithCollidingChar, 1, brokers) | ||
|
|
||
| val createTopic: Executable = () => createAndWaitTopic(createOpts) | ||
| assertDoesNotThrow(createTopic) |
Member
There was a problem hiding this comment.
I'm investigating why there will be compile error when directly using assertDoesNotThrow(() => createAndWaitTopic(createOpts)).
Contributor
|
Great find! Agree with @dengziming that we should have a test in |
3 tasks
hachikuji
approved these changes
Oct 28, 2022
hachikuji
left a comment
Contributor
There was a problem hiding this comment.
Since the fix is straightforward, I'm inclined to check in as is. I'm a tad anxious to get this patch since we are trying to bring kraft to production. I've opened a separate PR with a unit test for ReplicationControlManager: #12796.
hachikuji
pushed a commit
that referenced
this pull request
Oct 28, 2022
…letion (#12790) In #11910 , we added a feature to prevent topics with conflicting metrics names from being created. We added a map to store the normalized topic name to the topic names, but we didn't remove it correctly while deleting topics. This PR fixes this bug and add a test. Reviewers: Igor Soarez <i@soarez.me>, dengziming <dengziming1993@gmail.com>, Jason Gustafson <jason@confluent.io>
hachikuji
added a commit
that referenced
this pull request
Oct 29, 2022
This patch adds a unit test for topic recreation with colliding characters (such as `.`). This was broken up until #12790. Reviewers: José Armando García Sancio <jsancio@users.noreply.github.com>
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
…letion (apache#12790) In apache#11910 , we added a feature to prevent topics with conflicting metrics names from being created. We added a map to store the normalized topic name to the topic names, but we didn't remove it correctly while deleting topics. This PR fixes this bug and add a test. Reviewers: Igor Soarez <i@soarez.me>, dengziming <dengziming1993@gmail.com>, Jason Gustafson <jason@confluent.io>
guozhangwang
pushed a commit
to guozhangwang/kafka
that referenced
this pull request
Jan 25, 2023
…e#12796) This patch adds a unit test for topic recreation with colliding characters (such as `.`). This was broken up until apache#12790. Reviewers: José Armando García Sancio <jsancio@users.noreply.github.com>
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/kafka
that referenced
this pull request
Feb 9, 2024
…letion (apache#12790) In apache#11910 , we added a feature to prevent topics with conflicting metrics names from being created. We added a map to store the normalized topic name to the topic names, but we didn't remove it correctly while deleting topics. This PR fixes this bug and add a test. Reviewers: Igor Soarez <i@soarez.me>, dengziming <dengziming1993@gmail.com>, Jason Gustafson <jason@confluent.io>
rutvijmehta-harness
added a commit
to rutvijmehta-harness/kafka
that referenced
this pull request
Feb 9, 2024
…letion (apache#12790) (#90) In apache#11910 , we added a feature to prevent topics with conflicting metrics names from being created. We added a map to store the normalized topic name to the topic names, but we didn't remove it correctly while deleting topics. This PR fixes this bug and add a test. Reviewers: Igor Soarez <i@soarez.me>, dengziming <dengziming1993@gmail.com>, Jason Gustafson <jason@confluent.io> Co-authored-by: Luke Chen <showuon@gmail.com>
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/kafka
that referenced
this pull request
Feb 9, 2024
…e#12796) This patch adds a unit test for topic recreation with colliding characters (such as `.`). This was broken up until apache#12790. Reviewers: José Armando García Sancio <jsancio@users.noreply.github.com>
rutvijmehta-harness
added a commit
to rutvijmehta-harness/kafka
that referenced
this pull request
Feb 9, 2024
…e#12796) (#91) This patch adds a unit test for topic recreation with colliding characters (such as `.`). This was broken up until apache#12790. Reviewers: José Armando García Sancio <jsancio@users.noreply.github.com> Co-authored-by: Jason Gustafson <jason@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #11910 , we added a feature to prevent topics with conflicting metrics names from being created. We added a map to store the normalized topic name to the topic names, but we didn't remove it correctly while deleting topics. This PR fixes this bug and add a test.
Committer Checklist (excluded from commit message)