MINOR: Update of the PAPI testing classes to the latest implementation#12740
Merged
Conversation
mjsax
reviewed
Dec 29, 2022
mjsax
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR. Overall LGTM. A few minor comments/questions.
mjsax
reviewed
Oct 13, 2023
mjsax
left a comment
Member
There was a problem hiding this comment.
One minor question. Overall LGTM.
| public void process(final K key, final V value) { | ||
| delegate.process(new Record<>(key, value, context.timestamp(), context.headers())); | ||
| public void process(Record<KIn, VIn> record) { | ||
| delegate.process(new Record<>(record.key(), record.value(), record.timestamp(), record.headers())); |
Member
There was a problem hiding this comment.
Why do we need to make a deep copy? Can we not just forward record reference?
c6f380b to
870d98d
Compare
wcarlson5
pushed a commit
to wcarlson5/kafka
that referenced
this pull request
Mar 28, 2024
apache#12740) Reviewers: Matthias J. Sax <matthias@confluent.io>
clolov
pushed a commit
to clolov/kafka
that referenced
this pull request
Apr 5, 2024
apache#12740) Reviewers: Matthias J. Sax <matthias@confluent.io>
Phuc-Hong-Tran
pushed a commit
to Phuc-Hong-Tran/kafka
that referenced
this pull request
Jun 6, 2024
apache#12740) Reviewers: Matthias J. Sax <matthias@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The papi tests were still using the old PAPI classes. This makes it cumbersome to write tests for new PAPI functionality.
@mjsax This is the split out of the functionality which was proposed by the PR for KIP-813